Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: runtime/observatory/tests/service/get_source_report_test.dart

Issue 1753903003: Make getSourceReport public. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_source_report_test.dart
diff --git a/runtime/observatory/tests/service/get_source_report_test.dart b/runtime/observatory/tests/service/get_source_report_test.dart
index 006ef5b55285068689b6c10be79058dcdc246461..2f089b24b93acb8175d042138fba48a89d63394c 100644
--- a/runtime/observatory/tests/service/get_source_report_test.dart
+++ b/runtime/observatory/tests/service/get_source_report_test.dart
@@ -72,7 +72,7 @@ hasStoppedAtBreakpoint,
// Full script
var params = { 'reports' : ['Coverage'],
'scriptId' : func.location.script.id };
- var coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ var coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
expect(coverage['type'], equals('SourceReport'));
expect(coverage['ranges'].length, 6);
expect(coverage['ranges'][0], equals(expectedRange));
@@ -85,7 +85,7 @@ hasStoppedAtBreakpoint,
params = { 'reports' : ['Coverage'],
'scriptId' : func.location.script.id,
'forceCompile' : true };
- coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
expect(coverage['type'], equals('SourceReport'));
expect(coverage['ranges'].length, 6);
expect(allRangesCompiled(coverage), isTrue);
@@ -95,7 +95,7 @@ hasStoppedAtBreakpoint,
'scriptId' : func.location.script.id,
'tokenPos' : func.location.tokenPos,
'endTokenPos' : func.location.endTokenPos };
- coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
expect(coverage['type'], equals('SourceReport'));
expect(coverage['ranges'].length, 1);
expect(coverage['ranges'][0], equals(expectedRange));
@@ -105,7 +105,7 @@ hasStoppedAtBreakpoint,
// Full isolate
params = { 'reports' : ['Coverage'] };
- coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
expect(coverage['type'], equals('SourceReport'));
expect(coverage['ranges'].length, greaterThan(1));
expect(coverage['scripts'].length, greaterThan(1));
@@ -115,7 +115,7 @@ hasStoppedAtBreakpoint,
'scriptId' : func.location.script.id,
'tokenPos' : func.location.tokenPos,
'endTokenPos' : func.location.endTokenPos };
- coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
expect(coverage['type'], equals('SourceReport'));
expect(coverage['ranges'].length, 1);
var range = coverage['ranges'][0];
@@ -128,12 +128,12 @@ hasStoppedAtBreakpoint,
try {
params = { 'reports' : ['Coverage'],
'tokenPos' : func.location.tokenPos };
- coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
} on ServerRpcException catch(e) {
caughtException = true;
expect(e.code, equals(ServerRpcException.kInvalidParams));
expect(e.message,
- "_getSourceReport: the 'tokenPos' parameter requires the "
+ "getSourceReport: the 'tokenPos' parameter requires the "
"\'scriptId\' parameter");
}
expect(caughtException, isTrue);
@@ -143,12 +143,12 @@ hasStoppedAtBreakpoint,
try {
params = { 'reports' : ['Coverage'],
'endTokenPos' : func.location.endTokenPos };
- coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
} on ServerRpcException catch(e) {
caughtException = true;
expect(e.code, equals(ServerRpcException.kInvalidParams));
expect(e.message,
- "_getSourceReport: the 'endTokenPos' parameter requires the "
+ "getSourceReport: the 'endTokenPos' parameter requires the "
"\'scriptId\' parameter");
}
expect(caughtException, isTrue);
« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698