Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1753883002: Add the ability to deprecate Flatbuffer fields. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the ability to deprecate Flatbuffer fields. If an IDL field is marked as `@deprecated`, no setter will be generated for it, and the getter generated for it will throw an UnimplementedError. This is similar to the behavior of standard Flatbuffer tools (which generate neither setters nor getters for deprecated fields) except that we have to generate a getter in order to avoid warnings. Once we have begun using summaries in the wild, we will need to make use of this feature in order to avoid changing Id numbers and breaking backwards compatibility. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9a983bcbda79115fbffc4621d44f6b5f06e28948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -39 lines) Patch
M pkg/analyzer/tool/summary/generate.dart View 9 chunks +59 lines, -36 lines 0 comments Download
M pkg/analyzer/tool/summary/idl_model.dart View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-01 19:23:21 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-01 20:24:45 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-01 21:25:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a983bcbda79115fbffc4621d44f6b5f06e28948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698