Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175383005: Switch static text role on Windows. (Closed)

Created:
6 years, 10 months ago by dmazzoni
Modified:
6 years, 10 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Switch static text role on Windows. Using ROLE_SYSTEM_TEXT was only for legacy reasons, but ROLE_SYSTEM_STATICTEXT is better and seems to work fine with modern screen readers. We should revert if this causes problems for existing software that can't easily adapt to this change. BUG=328261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253475

Patch Set 1 #

Total comments: 9

Patch Set 2 : Add back missing stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -102 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M content/test/data/accessibility/a-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/a-with-img-expected-win.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M content/test/data/accessibility/aria-combobox-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-level-expected-win.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M content/test/data/accessibility/article-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/bdo-expected-win.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/br-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/canvas-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/contenteditable-descendants-expected-win.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M content/test/data/accessibility/dialog-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/div-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/dl-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/em-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/footer-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/heading-expected-win.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M content/test/data/accessibility/hr-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/input-types-expected-win.txt View 1 chunk +117 lines, -1 line 0 comments Download
M content/test/data/accessibility/label-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/landmark-expected-win.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M content/test/data/accessibility/list-markers-expected-win.txt View 1 chunk +17 lines, -1 line 0 comments Download
M content/test/data/accessibility/modal-dialog-closed-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/modal-dialog-in-iframe-closed-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/modal-dialog-in-iframe-opened-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/modal-dialog-opened-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/modal-dialog-stack-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/p-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/region-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/span-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/toolbar-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/ul-expected-win.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M content/test/data/accessibility/wbr-expected-win.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dmazzoni
Note that this is a trivial code change, plus lots of test expectations.
6 years, 10 months ago (2014-02-21 23:59:39 UTC) #1
aboxhall
lgtm https://codereview.chromium.org/175383005/diff/1/content/test/data/accessibility/bdo-expected-win.txt File content/test/data/accessibility/bdo-expected-win.txt (left): https://codereview.chromium.org/175383005/diff/1/content/test/data/accessibility/bdo-expected-win.txt#oldcode1 content/test/data/accessibility/bdo-expected-win.txt:1: # The spec states that <bdo> should have ...
6 years, 10 months ago (2014-02-25 17:20:27 UTC) #2
dmazzoni
https://codereview.chromium.org/175383005/diff/1/content/test/data/accessibility/bdo-expected-win.txt File content/test/data/accessibility/bdo-expected-win.txt (left): https://codereview.chromium.org/175383005/diff/1/content/test/data/accessibility/bdo-expected-win.txt#oldcode1 content/test/data/accessibility/bdo-expected-win.txt:1: # The spec states that <bdo> should have a ...
6 years, 10 months ago (2014-02-25 21:35:47 UTC) #3
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 10 months ago (2014-02-25 21:36:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/175383005/90001
6 years, 10 months ago (2014-02-25 21:37:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/175383005/90001
6 years, 10 months ago (2014-02-25 22:02:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/175383005/90001
6 years, 10 months ago (2014-02-25 22:30:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/175383005/90001
6 years, 10 months ago (2014-02-25 23:37:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/175383005/90001
6 years, 10 months ago (2014-02-26 00:22:23 UTC) #9
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:32:19 UTC) #10
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:41:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/175383005/90001
6 years, 10 months ago (2014-02-26 06:01:24 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 15:41:51 UTC) #13
Message was sent while issue was closed. 
Change committed as 253475

Powered by Google App Engine
This is Rietveld 408576698