Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175383002: Fix warnings on Ubuntu13 (Closed)

Created:
6 years, 10 months ago by scroggo
Modified:
6 years, 10 months ago
Reviewers:
hal.canary, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix warnings on Ubuntu13 Turn off warnings when building libwebp. Turn off warnings when building libjpeg. Initialize some variables immediately. NOTRY=True NOTREECHECKS=True BUG=skia:2213 BUG=skia:2214 Committed: http://code.google.com/p/skia/source/detail?r=13545

Patch Set 1 #

Patch Set 2 : Also disable warnings in jpeg. #

Patch Set 3 : Initialize some variables to remove warnings. #

Total comments: 2

Patch Set 4 : Respond to comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M gyp/libjpeg.gyp View 1 1 chunk +3 lines, -7 lines 0 comments Download
M gyp/libwebp.gyp View 5 chunks +5 lines, -1 line 0 comments Download
M src/animator/SkDisplayType.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
scroggo
6 years, 10 months ago (2014-02-21 18:42:21 UTC) #1
bsalomon
https://codereview.chromium.org/175383002/diff/80001/tests/GLProgramsTest.cpp File tests/GLProgramsTest.cpp (right): https://codereview.chromium.org/175383002/diff/80001/tests/GLProgramsTest.cpp#newcode158 tests/GLProgramsTest.cpp:158: attribIndices[0] = 0; lgtm, but maybe: int attribIndices[] = ...
6 years, 10 months ago (2014-02-21 19:00:27 UTC) #2
scroggo
https://codereview.chromium.org/175383002/diff/80001/tests/GLProgramsTest.cpp File tests/GLProgramsTest.cpp (right): https://codereview.chromium.org/175383002/diff/80001/tests/GLProgramsTest.cpp#newcode158 tests/GLProgramsTest.cpp:158: attribIndices[0] = 0; On 2014/02/21 19:00:28, bsalomon wrote: > ...
6 years, 10 months ago (2014-02-21 19:08:55 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 10 months ago (2014-02-21 19:08:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/175383002/150001
6 years, 10 months ago (2014-02-21 19:13:15 UTC) #5
scroggo
The CQ bit was unchecked by scroggo@google.com
6 years, 10 months ago (2014-02-21 19:15:25 UTC) #6
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 10 months ago (2014-02-21 19:15:25 UTC) #7
scroggo
The CQ bit was unchecked by scroggo@google.com
6 years, 10 months ago (2014-02-21 19:17:53 UTC) #8
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 10 months ago (2014-02-21 19:17:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 20:09:10 UTC) #10
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-21 20:09:10 UTC) #11
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 10 months ago (2014-02-21 20:11:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/175383002/150001
6 years, 10 months ago (2014-02-21 20:11:36 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 20:11:45 UTC) #14
Message was sent while issue was closed. 
Change committed as 13545

Powered by Google App Engine
This is Rietveld 408576698