Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1753813005: Fixed createImageData and added RequestAnimationFrameCallback for compat (Closed)

Created:
4 years, 9 months ago by terry
Modified:
4 years, 9 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@integration
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cherry-pick integration fix to master #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/dom/idl/dart/dart.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (2 generated)
terry
Committed patchset #1 (id:1) manually as b524161f8f9bc8c3a122047d604f7eec9507411b (presubmit successful).
4 years, 9 months ago (2016-03-02 21:18:51 UTC) #2
terry
Committed patchset #2 (id:20001) manually as d094857c12c8cef5cabb11268126643c99cd7c8e (presubmit successful).
4 years, 9 months ago (2016-03-02 21:23:31 UTC) #4
Jacob
lgtm https://codereview.chromium.org/1753813005/diff/20001/tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate (right): https://codereview.chromium.org/1753813005/diff/20001/tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate#newcode18 tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:18: JS('ImageData', '#.createImageData(#, #, null)', this, imagedata); this looks ...
4 years, 9 months ago (2016-03-02 22:19:05 UTC) #5
Jacob
4 years, 9 months ago (2016-03-02 22:19:40 UTC) #6
Message was sent while issue was closed. 
nevermind. reread the cl description.
lgtm

Powered by Google App Engine
This is Rietveld 408576698