Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1753813002: Unbust the old debugger (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Unbust the old debugger AFAICT the recent STL changes have introduced some QT conflicts. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753813002 Committed: https://skia.googlesource.com/skia/+/9ea8acdf3ff8b7787e59de8c393e12a72b34ddc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M debugger/QT/SkCanvasWidget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M debugger/QT/SkCanvasWidget.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.h View 1 chunk +2 lines, -2 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +1 line, -1 line 0 comments Download
M debugger/QT/SkGLWidget.h View 1 chunk +1 line, -1 line 0 comments Download
M debugger/QT/SkGLWidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M debugger/QT/SkRasterWidget.h View 2 chunks +5 lines, -5 lines 0 comments Download
M debugger/QT/SkRasterWidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M debugger/QT/SkSettingsWidget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/debugger.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 9 months ago (2016-03-01 16:42:51 UTC) #4
djsollen
lgtm
4 years, 9 months ago (2016-03-01 16:47:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753813002/1
4 years, 9 months ago (2016-03-01 17:08:47 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 17:28:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753813002/1
4 years, 9 months ago (2016-03-01 17:33:20 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 17:34:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9ea8acdf3ff8b7787e59de8c393e12a72b34ddc0

Powered by Google App Engine
This is Rietveld 408576698