Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1753803003: [test] Remove dependent commands. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove dependent commands. BUG= Committed: https://crrev.com/76876b9ae9079598347045021b72d5cbd706f791 Cr-Commit-Position: refs/heads/master@{#34428}

Patch Set 1 : Naive run without dep command #

Patch Set 2 : Coding #

Total comments: 2

Patch Set 3 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -110 lines) Patch
M test/cctest/cctest.h View 1 2 3 chunks +10 lines, -26 lines 0 comments Download
M test/cctest/cctest.cc View 1 2 2 chunks +7 lines, -10 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/heap-tester.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 11 chunks +42 lines, -36 lines 0 comments Download
M test/cctest/testcfg.py View 1 1 chunk +1 line, -10 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 3 chunks +2 lines, -17 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testrunner/objects/testcase.py View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753803003/1
4 years, 9 months ago (2016-03-02 09:20:36 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 09:37:32 UTC) #4
Michael Achenbach
PTAL https://codereview.chromium.org/1753803003/diff/20001/test/cctest/test-serialize.cc File test/cctest/test-serialize.cc (right): https://codereview.chromium.org/1753803003/diff/20001/test/cctest/test-serialize.cc#newcode247 test/cctest/test-serialize.cc:247: Serialize(isolate); FYI: The old "Serialize" test doesn't call ...
4 years, 9 months ago (2016-03-02 11:22:48 UTC) #7
Michael Achenbach
PTAL https://codereview.chromium.org/1753803003/diff/20001/test/cctest/test-serialize.cc File test/cctest/test-serialize.cc (right): https://codereview.chromium.org/1753803003/diff/20001/test/cctest/test-serialize.cc#newcode247 test/cctest/test-serialize.cc:247: Serialize(isolate); FYI: The old "Serialize" test doesn't call ...
4 years, 9 months ago (2016-03-02 11:22:48 UTC) #8
Michael Achenbach
FYI: Ran some tests on patch 2.
4 years, 9 months ago (2016-03-02 11:23:28 UTC) #9
Yang
On 2016/03/02 11:23:28, Michael Achenbach wrote: > FYI: Ran some tests on patch 2. C++ ...
4 years, 9 months ago (2016-03-02 11:40:28 UTC) #10
Jakob Kummerow
Python changes LGTM. Yay!
4 years, 9 months ago (2016-03-02 12:04:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753803003/40001
4 years, 9 months ago (2016-03-02 12:51:59 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 13:13:07 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 13:14:20 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/76876b9ae9079598347045021b72d5cbd706f791
Cr-Commit-Position: refs/heads/master@{#34428}

Powered by Google App Engine
This is Rietveld 408576698