Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4275)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

Issue 1753763002: Tests for notification preferences intents fired by the Android system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix setClassName call. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
index fa3a8315e4eb5454d1c699de92855984ed831603..f4338ea1de237dcc3367739964fa54caa31c0a86 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
@@ -226,7 +226,7 @@ public static void launchNotificationPreferences(Context context, Intent incomin
return;
}
- // Use the application context because it lives longer. When using he given context, it
+ // Use the application context because it lives longer. When using the given context, it
// may be stopped before the preferences intent is handled.
Context applicationContext = context.getApplicationContext();
@@ -328,8 +328,9 @@ private PendingIntent makePendingIntent(String action, long persistentNotificati
* @param tag A string identifier for this notification.
* @return The generated platform tag.
*/
- private static String makePlatformTag(long persistentNotificationId, String origin,
- @Nullable String tag) {
+ @VisibleForTesting
+ static String makePlatformTag(
+ long persistentNotificationId, String origin, @Nullable String tag) {
// The given tag may contain the separator character, so add it last to make reading the
// preceding origin token reliable. If no tag was specified (it is the default empty
// string), make the platform tag unique by appending the notification id.

Powered by Google App Engine
This is Rietveld 408576698