Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1753723003: Revert of [mojo-edk] Serialise windows handles into an "extra header" section. (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [mojo-edk] Serialise windows handles into an "extra header" section. (patchset #3 id:40001 of https://codereview.chromium.org/1740953002/ ) Reason for revert: Reverting per ARC++ request. Let's reland in a way that doesn't affect non-OSX POSIX. :| Original issue's description: > [mojo-edk] Serialise windows handles into an "extra header" section. > > This change introduces an "extra header" section of a channel message > header. On windows, platform handles are place into this section instead > of being appended to the end of a message. > > At the same time, make a couple of smaller changes: > 1. Allow the number of serialised handles to be less than the number > stated in the constructor. > 2. Add a has_mach_ports() helper function. > 3. Limit the number of attached handles. > > These changes are all prep work for Mach ports support. > > BUG=582468 > > Committed: https://crrev.com/fbebd41187198e7782b3fec9ddf9f155b9df1789 > Cr-Commit-Position: refs/heads/master@{#378099} TBR=amistry@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=582468 Committed: https://crrev.com/b49df35e75dab5406defaf166c9448fd3eaf7a26 Cr-Commit-Position: refs/heads/master@{#378530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -133 lines) Patch
M mojo/edk/system/channel.h View 5 chunks +16 lines, -32 lines 0 comments Download
M mojo/edk/system/channel.cc View 4 chunks +55 lines, -93 lines 0 comments Download
M mojo/edk/system/channel_posix.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_win.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Ken Rockot(use gerrit already)
Created Revert of [mojo-edk] Serialise windows handles into an "extra header" section.
4 years, 9 months ago (2016-03-01 18:31:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753723003/1
4 years, 9 months ago (2016-03-01 18:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753723003/1
4 years, 9 months ago (2016-03-01 19:03:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753723003/1
4 years, 9 months ago (2016-03-01 19:31:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 19:43:51 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 19:46:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b49df35e75dab5406defaf166c9448fd3eaf7a26
Cr-Commit-Position: refs/heads/master@{#378530}

Powered by Google App Engine
This is Rietveld 408576698