Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1753643002: [api] Use shallow copy for the template instantiation cache (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Use shallow copy for the template instantiation cache This means we can't cache templates that have object properties. Disable caching for those. BUG= R=verwaest@chromium.org Committed: https://crrev.com/adfea6af9f66a2079abe3eca9dbad49aee06874b Cr-Commit-Position: refs/heads/master@{#34402}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -66 lines) Patch
M src/api.cc View 2 1 chunk +8 lines, -1 line 0 comments Download
M src/api-natives.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 5 chunks +9 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
ptal splitting out the individual changes
4 years, 9 months ago (2016-03-01 10:52:25 UTC) #1
Toon Verwaest
lgtm
4 years, 9 months ago (2016-03-01 17:31:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753643002/40001
4 years, 9 months ago (2016-03-01 17:34:31 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-01 17:54:41 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 17:55:03 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/adfea6af9f66a2079abe3eca9dbad49aee06874b
Cr-Commit-Position: refs/heads/master@{#34402}

Powered by Google App Engine
This is Rietveld 408576698