Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175363004: Move webkit_glue_unittest.cc from webkit to content/child. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Move webkit_glue_unittest.cc from webkit to content/child. This unit test is already in content_unittests target and with the removal of src/webkit we need to move it over to content/. BUG=265753 TEST=content_unittests --gtest_filter=BlinkPlatformTest.* R=avi@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252812

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -107 lines) Patch
A + content/child/blink_platform_unittest.cc View 3 chunks +20 lines, -19 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
D webkit/glue/webkit_glue_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
tfarina
6 years, 10 months ago (2014-02-21 22:31:17 UTC) #1
Avi (use Gerrit)
lgtm Sure.
6 years, 10 months ago (2014-02-21 22:36:05 UTC) #2
tfarina
TBRing Darin for this.
6 years, 10 months ago (2014-02-22 02:39:26 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-22 02:41:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/175363004/2
6 years, 10 months ago (2014-02-22 02:41:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 03:23:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268396
6 years, 10 months ago (2014-02-22 03:23:25 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-22 04:48:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/175363004/2
6 years, 10 months ago (2014-02-22 04:49:07 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 08:03:43 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, browser_tests_swarm http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268461
6 years, 10 months ago (2014-02-22 08:03:43 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-22 14:15:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/175363004/2
6 years, 10 months ago (2014-02-22 14:15:34 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 16:52:44 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268512
6 years, 10 months ago (2014-02-22 16:52:45 UTC) #15
tfarina
6 years, 10 months ago (2014-02-22 18:59:54 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 manually as r252812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698