Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: third_party/WebKit/Source/platform/heap/Visitor.h

Issue 1753623002: Merge VisitorScope to Visitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added explicit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/Visitor.h
diff --git a/third_party/WebKit/Source/platform/heap/Visitor.h b/third_party/WebKit/Source/platform/heap/Visitor.h
index 443db172a7ead4857fe943db6881ba5ca5b2d90c..93164e4107d7b6b65b2014dd9853bac934ec38b5 100644
--- a/third_party/WebKit/Source/platform/heap/Visitor.h
+++ b/third_party/WebKit/Source/platform/heap/Visitor.h
@@ -317,7 +317,9 @@ public:
WeakProcessing,
};
- virtual ~Visitor() { }
+ static PassOwnPtr<Visitor> create(ThreadState*, BlinkGC::GCType);
+
+ virtual ~Visitor();
using VisitorHelper<Visitor>::mark;
@@ -374,31 +376,18 @@ public:
inline MarkingMode markingMode() const { return m_markingMode; }
protected:
- explicit Visitor(MarkingMode markingMode)
- : m_markingMode(markingMode)
- { }
+ Visitor(ThreadState*, MarkingMode);
virtual void registerWeakCellWithCallback(void**, WeakCallback) = 0;
private:
static Visitor* fromHelper(VisitorHelper<Visitor>* helper) { return static_cast<Visitor*>(helper); }
+ ThreadState* m_state;
const MarkingMode m_markingMode;
bool m_isGlobalMarkingVisitor;
};
-class VisitorScope final {
- STACK_ALLOCATED();
-public:
- VisitorScope(ThreadState*, BlinkGC::GCType);
- ~VisitorScope();
- Visitor* visitor() const { return m_visitor.get(); }
-
-private:
- ThreadState* m_state;
- OwnPtr<Visitor> m_visitor;
-};
-
} // namespace blink
#endif // Visitor_h
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.cpp ('k') | third_party/WebKit/Source/platform/heap/Visitor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698