third_party/WebKit/Source/platform/heap/ThreadState.cpp - Issue 1753623002: Merge VisitorScope to Visitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 1753623002: Merge VisitorScope to Visitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added explicit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp

diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp

index 664912e0808a04039fe4dfcf05f5456d0f8f4160..0d2254fd5c83231cfb4057e948b53fe4a05f88c1 100644

--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp

+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp

@@ -489,10 +489,10 @@ void ThreadState::threadLocalWeakProcessing()

// Due to the complexity, we just forbid allocations.

NoAllocationScope noAllocationScope(this);

- VisitorScope visitorScope(this, BlinkGC::ThreadLocalWeakProcessing);

+ OwnPtr<Visitor> visitor = Visitor::create(this, BlinkGC::ThreadLocalWeakProcessing);

// Perform thread-specific weak processing.

- while (popAndInvokeThreadLocalWeakCallback(visitorScope.visitor())) { }

+ while (popAndInvokeThreadLocalWeakCallback(visitor.get())) { }

m_threadLocalWeakCallbackStack->decommit();