Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1753623002: Merge VisitorScope to Visitor (Closed)

Created:
4 years, 9 months ago by keishi
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge VisitorScope to Visitor Merging because VisitorScope and Visitor have the same lifetime. No behavior change. BUG=None. Committed: https://crrev.com/7d65084979b7176f0dfaf5f8da16d0a80d9a7f35 Cr-Commit-Position: refs/heads/master@{#378718}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : added explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -70 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 7 chunks +25 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitor.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 2 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.cpp View 1 2 1 chunk +18 lines, -17 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753623002/1
4 years, 9 months ago (2016-03-01 05:55:51 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/100687)
4 years, 9 months ago (2016-03-01 06:08:32 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753623002/40001
4 years, 9 months ago (2016-03-01 06:34:46 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/189331)
4 years, 9 months ago (2016-03-01 07:42:57 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753623002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753623002/60001
4 years, 9 months ago (2016-03-01 07:58:07 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/31344)
4 years, 9 months ago (2016-03-01 11:34:06 UTC) #12
keishi
PTAL
4 years, 9 months ago (2016-03-02 07:05:36 UTC) #15
haraken
LGTM https://codereview.chromium.org/1753623002/diff/60001/third_party/WebKit/Source/platform/heap/MarkingVisitor.h File third_party/WebKit/Source/platform/heap/MarkingVisitor.h (right): https://codereview.chromium.org/1753623002/diff/60001/third_party/WebKit/Source/platform/heap/MarkingVisitor.h#newcode18 third_party/WebKit/Source/platform/heap/MarkingVisitor.h:18: MarkingVisitor(ThreadState* state) Add explicit.
4 years, 9 months ago (2016-03-02 07:13:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753623002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753623002/80001
4 years, 9 months ago (2016-03-02 07:27:24 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-02 10:38:32 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 10:39:45 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7d65084979b7176f0dfaf5f8da16d0a80d9a7f35
Cr-Commit-Position: refs/heads/master@{#378718}

Powered by Google App Engine
This is Rietveld 408576698