rewrite_to_chrome_style: Improve naming of iterator and type traits.

rewrite_to_chrome_style: Improve naming of iterator and type traits.

1) Type trait structs in WTF should keep constants as "value" rather
than as "kValue".
2) begin() and end() should be renamed to Begin() and End() unless they
actually return an iterator.

R=dcheng
BUG=584099
Committed: https://crrev.com/f362850470bb5f63c84013c04b52b3ec35fcb3b2
Cr-Commit-Position: refs/heads/master@{#378671}

[dcheng, 2016-03-01 23:58:03]

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:78: bool blink,
The double bools here are kind of hard to read, but enums would be pretty clunky
here as well.

Meh, I guess this is fine.

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:90: bool
IsBlinkOrWtfMethod(const clang::CXXMethodDecl& decl,
Wtf or WTF consistently, I think.

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:92: bool wtf) {
It looks like blink and wtf are both always true?

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:94: auto*
namespace_decl = clang::dyn_cast_or_null<clang::NamespaceDecl>(
Maybe this can just call out to IsDeclInBlinkOrWtf.

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:311:
clang::dyn_cast_or_null<clang::CXXRecordDecl>(decl.getDeclContext());
s/decl.getDeclContext()/decl_context/

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/tests/methods-original.cc (right):

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/tests/methods-original.cc:59: //
begin()/end() and friends are only renamed if they return an iterator.
don't

[danakj, 2016-03-02 00:32:12]

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:90: bool
IsBlinkOrWtfMethod(const clang::CXXMethodDecl& decl,
On 2016/03/01 23:58:02, dcheng wrote:
> Wtf or WTF consistently, I think.

Done.

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:92: bool wtf) {
On 2016/03/01 23:58:02, dcheng wrote:
> It looks like blink and wtf are both always true?

Yeh.. I was doing something I shouldn't have with this method. I can remove
them.

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:94: auto*
namespace_decl = clang::dyn_cast_or_null<clang::NamespaceDecl>(
On 2016/03/01 23:58:02, dcheng wrote:
> Maybe this can just call out to IsDeclInBlinkOrWtf.

Done.

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:311:
clang::dyn_cast_or_null<clang::CXXRecordDecl>(decl.getDeclContext());
On 2016/03/01 23:58:02, dcheng wrote:
> s/decl.getDeclContext()/decl_context/

Done.

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/tests/methods-original.cc (right):

https://codereview.chromium.org/1753563003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/tests/methods-original.cc:59: //
begin()/end() and friends are only renamed if they return an iterator.
On 2016/03/01 23:58:03, dcheng wrote:
> don't

Done.

[danakj, 2016-03-02 00:32:20]

PTAL

[dcheng, 2016-03-02 00:35:20]

lgtm assuming the rewriter handles the extra test case I proposed

https://codereview.chromium.org/1753563003/diff/60001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc (right):

https://codereview.chromium.org/1753563003/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc:8: using
my_iterator = MyIterator;
I think the problem case I was considering is if you have something like:

using my_iterator = char*;

[dcheng, 2016-03-02 00:37:00]

https://codereview.chromium.org/1753563003/diff/60001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc (right):

https://codereview.chromium.org/1753563003/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc:8: using
my_iterator = MyIterator;
On 2016/03/02 at 00:35:19, dcheng wrote:
> I think the problem case I was considering is if you have something like:
> 
> using my_iterator = char*;

Or perhaps something like this:

template<typename T>
class Vector {
  using iterator = T*;
  iterator begin();
  iterator end();
};

[danakj, 2016-03-02 01:00:48]

On 2016/03/02 00:37:00, dcheng wrote:
>
https://codereview.chromium.org/1753563003/diff/60001/tools/clang/rewrite_to_...
> File tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc (right):
> 
>
https://codereview.chromium.org/1753563003/diff/60001/tools/clang/rewrite_to_...
> tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc:8: using
> my_iterator = MyIterator;
> On 2016/03/02 at 00:35:19, dcheng wrote:
> > I think the problem case I was considering is if you have something like:
> > 
> > using my_iterator = char*;
> 
> Or perhaps something like this:
> 
> template<typename T>
> class Vector {
>   using iterator = T*;
>   iterator begin();
>   iterator end();
> };

Yep it works, I adjusted the test to cover it tho.

[danakj, 2016-03-02 01:01:37]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-02 01:01:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1753563003/#ps80001
(title: "clang-structs: test")

[commit-bot: I haz the power, 2016-03-02 01:02:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1753563003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1753563003/80001

[commit-bot: I haz the power, 2016-03-02 03:19:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-02 03:20:16]

Description was changed from

==========
rewrite_to_chrome_style: Improve naming of iterator and type traits.

1) Type trait structs in WTF should keep constants as "value" rather
than as "kValue".
2) begin() and end() should be renamed to Begin() and End() unless they
actually return an iterator.

R=dcheng
BUG=584099
==========

to

==========
rewrite_to_chrome_style: Improve naming of iterator and type traits.

1) Type trait structs in WTF should keep constants as "value" rather
than as "kValue".
2) begin() and end() should be renamed to Begin() and End() unless they
actually return an iterator.

R=dcheng
BUG=584099

Committed: https://crrev.com/f362850470bb5f63c84013c04b52b3ec35fcb3b2
Cr-Commit-Position: refs/heads/master@{#378671}
==========

[commit-bot: I haz the power, 2016-03-02 03:20:16]

Patchset 5 (id:??) landed as
https://crrev.com/f362850470bb5f63c84013c04b52b3ec35fcb3b2
Cr-Commit-Position: refs/heads/master@{#378671}