Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/payments/payment-request-interface.html

Issue 1753543002: PaymentRequest Mojo bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@interface
Patch Set: Combine if statement. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h » ('j') | third_party/WebKit/Source/modules/payments/MockPaymentRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/payments/payment-request-interface.html
diff --git a/third_party/WebKit/LayoutTests/payments/payment-request-interface.html b/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
index ebdc020c78510dc434e5224feb73f5dc642b4b3e..9d6379edbca199688932eaeb8c992b47949e3a0a 100644
--- a/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
+++ b/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
@@ -4,60 +4,223 @@
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<script>
+function substiute(originalObject, substiuteKeyValuePair) {
rwlbuis 2016/03/29 17:44:22 Typo: substitute substiute with substitute :)
please use gerrit instead 2016/03/29 22:15:44 Done.
+ for (var key in originalObject) {
+ if (originalObject.hasOwnProperty(key) && substiuteKeyValuePair.hasOwnProperty(key)) {
+ originalObject[key] = substiuteKeyValuePair[key];
+ }
+ }
+}
+
+function buildItem(optionalSubstituteKeyValuePair) {
+ var item = {'id': 'item_id', 'label': 'Item Description', 'amount': {'currencyCode': 'USD', 'value': '10.00'}};
+
+ if (optionalSubstituteKeyValuePair) {
+ substiute(item, optionalSubstituteKeyValuePair);
+ substiute(item['amount'], optionalSubstituteKeyValuePair);
+ }
+
+ return item;
+}
+
+function buildDetails(optionalDetailName, optionalSubstituteKeyValuePair) {
+ var details = {};
+ var detailNames = ['items', 'shippingOptions'];
+
+ for (var i in detailNames) {
+ if (optionalDetailName == detailNames[i]) {
+ details[detailNames[i]] = [buildItem(optionalSubstituteKeyValuePair)];
+ } else {
+ details[detailNames[i]] = [buildItem()];
+ }
+ }
+
+ return details;
+}
+
test(function() {
- new PaymentRequest([], {}, {}, {});
+ new PaymentRequest(['foo'], buildDetails(), {}, {});
}, 'Creating a PaymentRequest with empty parameters should not throw or crash.');
test(function() {
- new PaymentRequest([], {}, {}, {}, '');
+ new PaymentRequest(['foo'], buildDetails(), {}, {}, '');
}, 'Creating a PaymentRequest with extra parameters should not throw or crash.');
test(function() {
- new PaymentRequest([], {});
+ new PaymentRequest(['foo'], buildDetails());
}, 'Creating a PaymentRequest with omitted optional parameters should not throw or crash.');
test(function() {
- new PaymentRequest([], {}, undefined, undefined);
+ new PaymentRequest(['foo'], buildDetails(), undefined, undefined);
}, 'Creating a PaymentRequest with undefined optional parameters should not throw or crash.');
test(function() {
- new PaymentRequest([], {}, null, null);
+ new PaymentRequest(['foo'], buildDetails(), null, null);
}, 'Creating a PaymentRequest with null optional parameters should not throw or crash.');
-generate_tests(assert_throws, [
- ['PaymentRequest constructor should throw for incorrect parameter types.', null, function() {
- new PaymentRequest('', '', '', '')
- }],
- ['PaymentRequest constructor should throw for undefined required parameters.', null, function() {
- new PaymentRequest(undefined, undefined)
- }],
- ['PaymentRequest constructor should throw for null required parameter.', null, function() {
- new PaymentRequest(null, null)
- }]
-]);
-
test(function() {
- var request = new PaymentRequest([], {});
- assert_readonly(request, "shippingAddress", 'PaymentRequest should have a readonly shippingAddress property.');
- assert_readonly(request, "shippingOption", 'PaymentRequest should have a readonly shippingOption property.');
+ var request = new PaymentRequest(['foo'], buildDetails());
+ assert_readonly(request, 'shippingAddress', 'PaymentRequest should have a readonly shippingAddress property.');
+ assert_readonly(request, 'shippingOption', 'PaymentRequest should have a readonly shippingOption property.');
}, 'PaymentRequest should have readonly shippingAddress and shippingOption properties.');
test(function() {
- var request = new PaymentRequest([], {});
+ var request = new PaymentRequest(['foo'], buildDetails());
assert_not_equals(request.onshippingaddresschange, undefined, 'PaymentRequest should have onShippingAddressChange event.');
assert_not_equals(request.onshippingoptionchange, undefined, 'PaymentRequest should have onShippingOptionChange event.');
}, 'PaymentRequest should have onShippingAddressChange and onShippingOptionChange events.');
-
test(function() {
- var request = new PaymentRequest([], {});
+ var request = new PaymentRequest(['foo'], buildDetails());
assert_not_equals(request.abort, undefined, 'PaymentRequest should have abort() method.');
assert_not_equals(request.show, undefined, 'PaymentRequest should have show() method.');
}, 'PaymentRequest should have methods abort() and show().');
test(function() {
- var request = new PaymentRequest([], {});
- request.abort();
+ var request = new PaymentRequest(['foo'], buildDetails());
request.show();
+ request.abort();
}, 'PaymentRequest.abort() and PaymentRequest.show() should take no parameters.');
+
+test(function() {
+ var request = new PaymentRequest(['foo'], buildDetails(), {'requestShipping': true}, {'foo': {'gateway': 'bar'}});
+ request.show();
+ request.abort();
+}, 'Valid data causes no errors.');
+
+test(function() {
+ var request = new PaymentRequest(['foo'], buildDetails('shippingOptions', {'id': 'standard'}));
+ assert_equals('standard', request.shippingOption);
+}, 'Shipping option identifier should default to the single provided option.');
+
+test(function() {
+ var request = new PaymentRequest(['foo'], {"items": [buildItem()]});
+ assert_equals(null, request.shippingOption);
+}, 'Shipping option identifier should be null when no shipping options are provided.');
+
+test(function() {
+ var request = new PaymentRequest(['foo'], {'items': [buildItem()], 'shippingOptions': [buildItem({'id': 'standard'}), buildItem({'id': 'express'})]});
+ assert_equals(null, request.shippingOption);
+}, 'Shipping option identifier should be null at first when multiple shipping options are provided.');
+
+generate_tests(assert_throws, [
+ ['PaymentRequest constructor should throw for incorrect parameter types.', null, function() {
+ new PaymentRequest('', '', '', '')
+ }],
+ ['PaymentRequest constructor should throw for undefined required parameters.', null, function() {
+ new PaymentRequest(undefined, undefined)
+ }],
+ ['PaymentRequest constructor should throw for null required parameter.', null, function() {
+ new PaymentRequest(null, null)
+ }],
+ ['Empty list of supported payment method identifiers should throw.', null, function() {
+ new PaymentRequest([], buildDetails())
+ }],
+ ['Keys in payment method specific data object should match accepted method identifiers.', null, function() {
+ new PaymentRequest(['foo'], buildDetails(), {}, {'bar': {'gateway': 'baz'}})
+ }],
+ ['Empty details should throw', null, function() {
+ new PaymentRequest(['foo'], {})
+ }],
+ ['Empty items should throw', null, function() {
+ new PaymentRequest(['foo'], {'items': []})
+ }],
+ ['Aborting before showing should throw.', null, function() {
+ new PaymentRequest(['foo'], buildDetails()).abort()
+ }],
+
+ // Payment method specific data should be a JSON-serializable object.
+ ['Array value for payment method specific data parameter should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(), {}, [])
+ }],
+ ['String value for payment method specific data parameter should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(), {}, 'foo')
+ }],
+ ['Numeric value for payment method specific data parameter should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(), {}, 42)
+ }],
+
+ // Values in payment method specific data object should be JSON-serializable objects.
+ ['Array value for one of the payment method specific data pieces should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(), {}, {'foo': []})
+ }],
+ ['String value for one of the payment method specific data pieces should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(), {}, {'foo': 'bar'})
+ }],
+ ['Numeric value for one of the payment method specific data pieces should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(), {}, {'foo': 42})
+ }],
+]);
+
+var detailNames = ['items', 'shippingOptions'];
+for (var i in detailNames) {
+ generate_tests(assert_throws, [
+ // Invalid currency code formats.
+ ['Invalid currency code US1 should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'currencyCode': 'US1'}))
+ }],
+ ['Invalid currency code US should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'currencyCode': 'US'}))
+ }],
+ ['Invalid currency code USDO should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'currencyCode': 'USDO'}))
+ }],
+ ['Invalid currency code usd should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'currencyCode': 'usd'}))
+ }],
+ ['Empty currency code should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'currencyCode': ''}))
+ }],
+ ['Null currency code should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'currencyCode': null}))
+ }],
+ ['Undefined currency code should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'currencyCode': undefined}))
+ }],
+
+ // Invalid amount formats.
+ ['Invalid amount "-" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '-'}))
+ }],
+ ['Invalid amount "notdigits" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': 'notdigits'}))
+ }],
+ ['Invalid amount "ALSONOTDIGITS" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': 'ALSONOTDIGITS'}))
+ }],
+ ['Invalid amount "10." should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '10.'}))
+ }],
+ ['Invalid amount ".99" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '.99'}))
+ }],
+ ['Invalid amount "-10." should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '-10.'}))
+ }],
+ ['Invalid amount "-.99" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '-.99'}))
+ }],
+ ['Invalid amount "10-" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '10-'}))
+ }],
+ ['Invalid amount "1-0" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '1-0'}))
+ }],
+ ['Invalid amount "1.0.0" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '1.0.0'}))
+ }],
+ ['Invalid amount "1/3" should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': '1/3'}))
+ }],
+ ['Empty amount should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': ''}))
+ }],
+ ['Null amount should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': null}))
+ }],
+ ['Undefined amount should throw', null, function() {
+ new PaymentRequest(['foo'], buildDetails(detailNames[i], {'value': undefined}))
+ }],
+ ]);
+}
</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h » ('j') | third_party/WebKit/Source/modules/payments/MockPaymentRequest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698