content/browser/android/content_view_core_impl.cc - Issue 1753493002: Avoid updating frame info while detached from activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 1753493002: Avoid updating frame info while detached from activity (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2661

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 90b001b705e877d1385359930e45d251065993a3..e90d2c5ad1f9d9e31ebddb0925821c327f42eb28 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -422,7 +422,7 @@ void ContentViewCoreImpl::UpdateFrameInfo(

bool is_mobile_optimized_hint) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);

- if (obj.is_null())

+ if (obj.is_null() || !window_android_)

return;

window_android_->set_content_offset(

« no previous file with comments | « no previous file | no next file » | no next file with comments »