Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: ui/views/widget/widget_interactive_uitest.cc

Issue 1753473003: A window should not get activated or get input focus if it's behind the lock screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify the test to use NativeWidgetAura when initializing widget. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/widget.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_interactive_uitest.cc
diff --git a/ui/views/widget/widget_interactive_uitest.cc b/ui/views/widget/widget_interactive_uitest.cc
index d077c3d4b3b5a160afbcd99e34614c0846517346..e9f9397c01b52c9b1ee21372f9505247c31a0063 100644
--- a/ui/views/widget/widget_interactive_uitest.cc
+++ b/ui/views/widget/widget_interactive_uitest.cc
@@ -1172,31 +1172,6 @@ TEST_F(WidgetTestInteractive, MAYBE_ExitFullscreenRestoreState) {
RunPendingMessages();
}
-// Testing widget delegate that creates a widget with a single view, which
-// should be initially focused.
-class TestInitialFocusWidgetDelegate : public TestDesktopWidgetDelegate {
- public:
- explicit TestInitialFocusWidgetDelegate(gfx::NativeWindow context)
- : view_(new View) {
- view_->SetFocusable(true);
-
- Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);
- params.context = context;
- InitWidget(params);
- GetWidget()->GetContentsView()->AddChildView(view_);
- }
-
- View* view() { return view_; }
-
- // DialogDelegateView:
- View* GetInitiallyFocusedView() override { return view_; }
-
- private:
- View* view_;
-
- DISALLOW_COPY_AND_ASSIGN(TestInitialFocusWidgetDelegate);
-};
-
// Testing initial focus is assigned properly for normal top-level widgets,
// and subclasses that specify a initially focused child view.
TEST_F(WidgetTestInteractive, InitialFocus) {
« no previous file with comments | « ui/views/widget/widget.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698