Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: net/quic/quic_spdy_stream.cc

Issue 1753453003: Deprecate --gfe2_reloadable_flag_quic_supports_trailers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115228444
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_spdy_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_spdy_stream.cc
diff --git a/net/quic/quic_spdy_stream.cc b/net/quic/quic_spdy_stream.cc
index d764283986ce0cec75a8b10bb0a13f22990dd5d5..9e0b0aea39201d26371a767c55adbb04e9766934 100644
--- a/net/quic/quic_spdy_stream.cc
+++ b/net/quic/quic_spdy_stream.cc
@@ -96,9 +96,6 @@ size_t QuicSpdyStream::WriteHeaders(
size_t QuicSpdyStream::WriteTrailers(
SpdyHeaderBlock trailer_block,
QuicAckListenerInterface* ack_notifier_delegate) {
- if (!FLAGS_quic_supports_trailers) {
- return 0;
- }
if (fin_sent()) {
QUIC_BUG << "Trailers cannot be sent after a FIN.";
return 0;
@@ -151,8 +148,7 @@ bool QuicSpdyStream::IsDoneReading() const {
bool QuicSpdyStream::HasBytesToRead() const {
bool headers_to_read = !decompressed_headers_.empty();
bool body_to_read = sequencer()->HasBytesToRead();
- bool trailers_to_read =
- (FLAGS_quic_supports_trailers && !decompressed_trailers_.empty());
+ bool trailers_to_read = !decompressed_trailers_.empty();
return headers_to_read || body_to_read || trailers_to_read;
}
@@ -174,7 +170,7 @@ void QuicSpdyStream::SetPriority(SpdyPriority priority) {
}
void QuicSpdyStream::OnStreamHeaders(StringPiece headers_data) {
- if (!FLAGS_quic_supports_trailers || !headers_decompressed_) {
+ if (!headers_decompressed_) {
headers_data.AppendToString(&decompressed_headers_);
} else {
DCHECK(!trailers_decompressed_);
@@ -188,7 +184,7 @@ void QuicSpdyStream::OnStreamHeadersPriority(SpdyPriority priority) {
}
void QuicSpdyStream::OnStreamHeadersComplete(bool fin, size_t frame_len) {
- if (!FLAGS_quic_supports_trailers || !headers_decompressed_) {
+ if (!headers_decompressed_) {
OnInitialHeadersComplete(fin, frame_len);
} else {
OnTrailingHeadersComplete(fin, frame_len);
@@ -266,9 +262,6 @@ bool QuicSpdyStream::FinishedReadingHeaders() const {
}
bool QuicSpdyStream::FinishedReadingTrailers() const {
- if (!FLAGS_quic_supports_trailers) {
- return true;
- }
// If no further trailing headers are expected, and the decompressed trailers
// (if any) have been consumed, then reading of trailers is finished.
bool no_more_trailers = fin_received() || trailers_decompressed_;
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_spdy_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698