remove checked mode from build_sdk. Saves ~25% from build SDK time

remove checked mode from build_sdk. Saves ~25% from build SDK time

Committed: https://github.com/dart-lang/dev_compiler/commit/45637a47ff852976e8155acf2489a1d462b64574

[Jennifer Messerly, 2016-02-29 21:23:50]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-02-29 21:23:50]

It's still way slower to build than it used to be, though. Not sure what's going
on.

[Brian Wilkerson, 2016-02-29 21:32:16]

> It's still way slower to build than it used to be, though. Not sure what's
going
> on.

When did you notice the slow down? Is it related to building summaries?

In any case, are you sure it's a good idea to turn off checked mode? I assume we
originally expected it to help us find bad builds, but maybe it doesn't help as
much as hoped.

[Jennifer Messerly, 2016-02-29 21:48:43]

On 2016/02/29 21:32:16, Brian Wilkerson wrote:
> > It's still way slower to build than it used to be, though. Not sure what's
> going
> > on.
> 
> When did you notice the slow down? Is it related to building summaries?

Not sure. I haven't worked on DDC code generator in a while. Could be anything
from the last several months. dart:html, extension method changes, nullable
inference, closure compiler support, analyzer changes, ... that's just a few
guesses.

> In any case, are you sure it's a good idea to turn off checked mode? I assume
we
> originally expected it to help us find bad builds, but maybe it doesn't help
as
> much as hoped.

Not sure what "find bad builds" means?

It gives us some coverage of js_codegen, but we get a *lot* of coverage from
running the language tests. I don't think this little bit here adds much. And
it's hurting my iteration cycle right now ... waiting 30 seconds to see the
affect of a change is painful =(

[Brian Wilkerson, 2016-02-29 21:56:07]

Never mind. I should have looked more carefully. I saw "build_sdk" and thought
you were talking about the build.py target "create_sdk".

[Jennifer Messerly, 2016-03-02 01:27:57]

Vijay and I chatted more about this ... we were wondering if it's possible we're
analyzing the SDK twice, once in the SDK Analysis Context and once in the normal
SDK context. That would explain the timing numbers we're seeing (about 2x higher
than they should be). Anyway something to investigate.

@Vijay -- I think you said this "LGTM" in the email thread?

[Jennifer Messerly, 2016-03-08 19:03:30]

On 2016/03/02 01:27:57, John Messerly wrote:
> Vijay and I chatted more about this ... we were wondering if it's possible
we're
> analyzing the SDK twice, once in the SDK Analysis Context and once in the
normal
> SDK context. That would explain the timing numbers we're seeing (about 2x
higher
> than they should be). Anyway something to investigate.
> 
> @Vijay -- I think you said this "LGTM" in the email thread?

Going to land based on email LGTM :)
https://groups.google.com/a/dartlang.org/d/msg/dev-compiler/q2V70BPlS-k/M_IQW...

[Jennifer Messerly, 2016-03-08 19:03:36]

Description was changed from

==========
remove checked mode from build_sdk. Saves ~25% from build SDK time
==========

to

==========
remove checked mode from build_sdk. Saves ~25% from build SDK time

Committed:
https://github.com/dart-lang/dev_compiler/commit/45637a47ff852976e8155acf2489...
==========

[Jennifer Messerly, 2016-03-08 19:03:38]

Committed patchset #1 (id:1) manually as
45637a47ff852976e8155acf2489a1d462b64574 (presubmit successful).