Add sticky key support for AltGr

Add sticky key support for AltGr

BUG=335368
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255116

[Zachary Kuznia, 2014-02-22 01:46:42]

Please take a look

[Tim Song, 2014-02-23 02:07:32]

https://codereview.chromium.org/175343007/diff/1/ash/sticky_keys/sticky_keys_...
File ash/sticky_keys/sticky_keys_overlay.cc (right):

https://codereview.chromium.org/175343007/diff/1/ash/sticky_keys/sticky_keys_...
ash/sticky_keys/sticky_keys_overlay.cc:164: AddKeyLabel(ui::EF_ALTGR_DOWN,
We should only show this label if the current keyboard makes a distinction
between Alt and AltGr. I would take a look at the X11 XGetModifierMapping
function for doing this.

Also take a look at this mock as the AltGr and right Ctrl modifiers should be
laid out slightly differently:
https://docs.google.com/a/google.com/presentation/d/1DoqmujKSf9bCbK1SM8NYi1rZ...

[Zachary Kuznia, 2014-02-24 19:28:02]

https://codereview.chromium.org/175343007/diff/1/ash/sticky_keys/sticky_keys_...
File ash/sticky_keys/sticky_keys_overlay.cc (right):

https://codereview.chromium.org/175343007/diff/1/ash/sticky_keys/sticky_keys_...
ash/sticky_keys/sticky_keys_overlay.cc:164: AddKeyLabel(ui::EF_ALTGR_DOWN,
On 2014/02/23 02:07:32, Tim Song wrote:
> We should only show this label if the current keyboard makes a distinction
> between Alt and AltGr. I would take a look at the X11 XGetModifierMapping
> function for doing this.
> 
> Also take a look at this mock as the AltGr and right Ctrl modifiers should be
> laid out slightly differently:
>
https://docs.google.com/a/google.com/presentation/d/1DoqmujKSf9bCbK1SM8NYi1rZ...

Sounds reasonable.  I'd prefer to split the UI changes into a different CL,
however, as they can be isolated from the functional change.

[Zachary Kuznia, 2014-03-04 00:01:16]

On 2014/02/24 19:28:02, Zachary Kuznia wrote:
>
https://codereview.chromium.org/175343007/diff/1/ash/sticky_keys/sticky_keys_...
> File ash/sticky_keys/sticky_keys_overlay.cc (right):
> 
>
https://codereview.chromium.org/175343007/diff/1/ash/sticky_keys/sticky_keys_...
> ash/sticky_keys/sticky_keys_overlay.cc:164: AddKeyLabel(ui::EF_ALTGR_DOWN,
> On 2014/02/23 02:07:32, Tim Song wrote:
> > We should only show this label if the current keyboard makes a distinction
> > between Alt and AltGr. I would take a look at the X11 XGetModifierMapping
> > function for doing this.
> > 
> > Also take a look at this mock as the AltGr and right Ctrl modifiers should
be
> > laid out slightly differently:
> >
>
https://docs.google.com/a/google.com/presentation/d/1DoqmujKSf9bCbK1SM8NYi1rZ...
> 
> Sounds reasonable.  I'd prefer to split the UI changes into a different CL,
> however, as they can be isolated from the functional change.

As discussed offline, it was decided layout should remain inline.

[Tim Song, 2014-03-04 17:50:57]

LGTM, but please find a solution for determining if the keyboard layout has
AltGr.

[Zachary Kuznia, 2014-03-04 22:30:10]

The CQ bit was checked by zork@chromium.org

[Zachary Kuznia, 2014-03-04 22:30:19]

The CQ bit was unchecked by zork@chromium.org

[Zachary Kuznia, 2014-03-04 22:35:20]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-03-04 22:37:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/175343007/240001

[commit-bot: I haz the power, 2014-03-04 23:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-04 23:58:26]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Zachary Kuznia, 2014-03-04 23:59:10]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-03-05 00:05:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/175343007/240001

[commit-bot: I haz the power, 2014-03-05 01:21:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/175343007/240001

[commit-bot: I haz the power, 2014-03-05 06:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 06:17:00]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
content_browsertests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Zachary Kuznia, 2014-03-05 19:17:16]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-03-05 19:17:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/175343007/240001

[commit-bot: I haz the power, 2014-03-05 19:42:41]

Change committed as 255116