Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: remoting/protocol/pairing_registry.cc

Issue 175343006: Fix getPairedClients for un-elevated native messaging process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remoting_core
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/pairing_registry.cc
diff --git a/remoting/protocol/pairing_registry.cc b/remoting/protocol/pairing_registry.cc
index e33b59d059df2ee54362b395e78827d3ccd22881..edf085cd090ad331d3465fe135aa366f881cab74 100644
--- a/remoting/protocol/pairing_registry.cc
+++ b/remoting/protocol/pairing_registry.cc
@@ -90,7 +90,9 @@ bool PairingRegistry::Pairing::operator==(const Pairing& other) const {
}
bool PairingRegistry::Pairing::is_valid() const {
- return !client_id_.empty() && !shared_secret_.empty();
+ // |shared_secret_| is optional. It will be empty on Windows because the
+ // privileged registry key can only be read in the elevated host process.
Jamie 2014/02/22 00:28:39 Could we fix this by setting a dummy value for the
+ return !client_id_.empty();
}
PairingRegistry::PairingRegistry(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698