Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175343006: Fix getPairedClients for un-elevated native messaging process. (Closed)

Created:
6 years, 10 months ago by weitao
Modified:
6 years, 10 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remoting_core
Visibility:
Public.

Description

Fix getPairedClients for un-elevated native messaging process. Without this change the un-elevated native messaging process will return an empty list because the pairings are considered invalid. BUG=345951 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252848

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M remoting/protocol/pairing_registry.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 14 (0 generated)
weitao
6 years, 10 months ago (2014-02-22 00:17:24 UTC) #1
Jamie
https://codereview.chromium.org/175343006/diff/1/remoting/protocol/pairing_registry.cc File remoting/protocol/pairing_registry.cc (right): https://codereview.chromium.org/175343006/diff/1/remoting/protocol/pairing_registry.cc#newcode94 remoting/protocol/pairing_registry.cc:94: // privileged registry key can only be read in ...
6 years, 10 months ago (2014-02-22 00:28:39 UTC) #2
Jamie
lgtm
6 years, 10 months ago (2014-02-22 01:15:16 UTC) #3
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 10 months ago (2014-02-22 01:33:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/175343006/1
6 years, 10 months ago (2014-02-22 01:41:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 03:40:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268404
6 years, 10 months ago (2014-02-22 03:40:11 UTC) #7
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-22 05:30:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/175343006/1
6 years, 10 months ago (2014-02-22 05:31:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 08:52:23 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268471
6 years, 10 months ago (2014-02-22 08:52:23 UTC) #11
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-23 04:13:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/175343006/1
6 years, 10 months ago (2014-02-23 04:14:01 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-23 08:05:10 UTC) #14
Message was sent while issue was closed. 
Change committed as 252848

Powered by Google App Engine
This is Rietveld 408576698