Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1753403002: Move IsValidOriginIdentifier into appropriate header (Closed)

Created:
4 years, 9 months ago by jsbell
Modified:
4 years, 9 months ago
Reviewers:
michaeln, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move IsValidOriginIdentifier into appropriate header It should live with the other DatabaseIdentifier-wrangling functions. BUG=591240 R=michaeln@chromium.org Committed: https://crrev.com/9863aae9883b2fdc5580ec0f1c265f5dac7b7073 Cr-Commit-Position: refs/heads/master@{#379023}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -35 lines) Patch
M content/browser/database_util_unittest.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/database_identifier_unittest.cc View 1 chunk +28 lines, -0 lines 1 comment Download
M storage/browser/database/database_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/database/database_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M storage/common/database/database_identifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
M storage/common/database/database_identifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jsbell
michaeln@ - please take a look? https://codereview.chromium.org/1753403002/diff/1/content/common/database_identifier_unittest.cc File content/common/database_identifier_unittest.cc (right): https://codereview.chromium.org/1753403002/diff/1/content/common/database_identifier_unittest.cc#newcode259 content/common/database_identifier_unittest.cc:259: TEST(DatabaseIdentifierTest, OriginIdentifiers) { ...
4 years, 9 months ago (2016-03-02 20:29:10 UTC) #1
michaeln
lgtm
4 years, 9 months ago (2016-03-02 23:54:26 UTC) #2
jsbell
jam@ - can you do OWNERS review? (and CQ if LG)
4 years, 9 months ago (2016-03-03 00:23:29 UTC) #4
jam
lgtm
4 years, 9 months ago (2016-03-03 16:39:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753403002/1
4 years, 9 months ago (2016-03-03 16:39:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 17:02:30 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 17:03:47 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9863aae9883b2fdc5580ec0f1c265f5dac7b7073
Cr-Commit-Position: refs/heads/master@{#379023}

Powered by Google App Engine
This is Rietveld 408576698