Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1753363002:
Revert of Instantiate instance templates instead of doing construct calls (Closed)
|
Created:
4 years, 9 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 9 months ago CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ )
Reason for revert:
It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%28NVIDIA%29/builds/614
In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place.
Original issue's description:
> Instantiate instance templates instead of doing construct calls
>
> This reduces the calls to V8 to create new wrappers. We also don't rely
> on invoking the function anyways, but instead cache results.
>
> BUG=
> R=verwaest@chromium.org
>
> Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4
> Cr-Commit-Position: refs/heads/master@{#378497}
TBR=verwaest@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
NOTRY=true
Committed: https://crrev.com/6987deba28b2c7bb58dceffc21223f7ff4ec5e7a
Cr-Commit-Position: refs/heads/master@{#378874}
Patch Set 1 #
Messages
Total messages: 16 (5 generated)
Created Revert of Instantiate instance templates instead of doing construct calls
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753363002/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753363002/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753363002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/03/02 20:16:00, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Filed http://crbug.com/591527 about the resource_bundle.cc failure. I'm forcing this through NOTRY=true because we need to know whether this is the cause of the failure.
Description was changed from ========== Revert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ ) Reason for revert: It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%... In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place. Original issue's description: > Instantiate instance templates instead of doing construct calls > > This reduces the calls to V8 to create new wrappers. We also don't rely > on invoking the function anyways, but instead cache results. > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4 > Cr-Commit-Position: refs/heads/master@{#378497} TBR=verwaest@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= ========== to ========== Revert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ ) Reason for revert: It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%... In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place. Original issue's description: > Instantiate instance templates instead of doing construct calls > > This reduces the calls to V8 to create new wrappers. We also don't rely > on invoking the function anyways, but instead cache results. > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4 > Cr-Commit-Position: refs/heads/master@{#378497} TBR=verwaest@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753363002/1
Message was sent while issue was closed.
Description was changed from ========== Revert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ ) Reason for revert: It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%... In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place. Original issue's description: > Instantiate instance templates instead of doing construct calls > > This reduces the calls to V8 to create new wrappers. We also don't rely > on invoking the function anyways, but instead cache results. > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4 > Cr-Commit-Position: refs/heads/master@{#378497} TBR=verwaest@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true ========== to ========== Revert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ ) Reason for revert: It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%... In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place. Original issue's description: > Instantiate instance templates instead of doing construct calls > > This reduces the calls to V8 to create new wrappers. We also don't rely > on invoking the function anyways, but instead cache results. > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4 > Cr-Commit-Position: refs/heads/master@{#378497} TBR=verwaest@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ ) Reason for revert: It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%... In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place. Original issue's description: > Instantiate instance templates instead of doing construct calls > > This reduces the calls to V8 to create new wrappers. We also don't rely > on invoking the function anyways, but instead cache results. > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4 > Cr-Commit-Position: refs/heads/master@{#378497} TBR=verwaest@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true ========== to ========== Revert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ ) Reason for revert: It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%... In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place. Original issue's description: > Instantiate instance templates instead of doing construct calls > > This reduces the calls to V8 to create new wrappers. We also don't rely > on invoking the function anyways, but instead cache results. > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4 > Cr-Commit-Position: refs/heads/master@{#378497} TBR=verwaest@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true Committed: https://crrev.com/6987deba28b2c7bb58dceffc21223f7ff4ec5e7a Cr-Commit-Position: refs/heads/master@{#378874} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6987deba28b2c7bb58dceffc21223f7ff4ec5e7a Cr-Commit-Position: refs/heads/master@{#378874}
Message was sent while issue was closed.
LGTM to revert.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1764693002/ by kbr@chromium.org. The reason for reverting is: This wasn't the cause of the test failures; see http://crbug.com/591705 . It must have been a different CL. . |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
