Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1753273002: Specialize helper methods in the LookupIterator by is_element. (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Specialize helper methods in the LookupIterator by is_element. This speeds up lookup. BUG= Committed: https://crrev.com/6eb483f8782e32d32f75d091fea4b50846210372 Cr-Commit-Position: refs/heads/master@{#34430}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -52 lines) Patch
M src/lookup.h View 1 2 7 chunks +23 lines, -12 lines 0 comments Download
M src/lookup.cc View 1 19 chunks +62 lines, -40 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-02 13:00:43 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-02 13:09:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753273002/40001
4 years, 9 months ago (2016-03-02 13:55:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 14:19:13 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 14:19:18 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6eb483f8782e32d32f75d091fea4b50846210372
Cr-Commit-Position: refs/heads/master@{#34430}

Powered by Google App Engine
This is Rietveld 408576698