Eliminate recursion in SVGTextMetricsBuilder::walkTree

Eliminate recursion in SVGTextMetricsBuilder::walkTree

This tree-traveral can be trivially rewritten as a pre-order traversal
using RenderObject::nextInPreOrderAfterChildren.

Also fold the branches in the RenderSVGInlineText case to reduce the
number of callsites to measureTextRenderer.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168005

[fs, 2014-02-21 16:56:23]

The starting CL of some refactoring of this class in order to reduce (eliminate)
state. PTAL, and let me know if you have any other issues in this area that'd
you'd want scratched.

(Try-bots are currently failing due to the recently added presubmit-step -
hopefully they should be more green without that...)

[rwlbuis, 2014-02-21 19:44:40]

On 2014/02/21 16:56:23, fs wrote:
> The starting CL of some refactoring of this class in order to reduce
(eliminate)
> state. PTAL, and let me know if you have any other issues in this area that'd
> you'd want scratched.
> 
> (Try-bots are currently failing due to the recently added presubmit-step -
> hopefully they should be more green without that...)

Could you re-upload? I am hoping side-by-side diff gives a better (colored at
the very least) diff, right now it gives that annoying chunk mismatch message.

[fs, 2014-02-26 17:09:29]

Ping.

[Stephen Chennney, 2014-02-26 19:38:38]

lgtm

[fs, 2014-02-27 08:45:14]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-02-27 08:45:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/175323002/90001

[commit-bot: I haz the power, 2014-02-27 10:21:18]

Change committed as 168005