Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1753213002: [interpreter] Make optimized code map more flexible. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Make optimized code map more flexible. This relaxes the constraints of the optimized code map in order to be able to update existing entries. It also simplifies the interface a little bit. We can now insert an entry for a newly allocated literals array together with previously cached context-independent code. R=mvstanton@chromium.org Committed: https://crrev.com/9fd5261d7f581210ff58a0a51b49051ba27c13ff Cr-Commit-Position: refs/heads/master@{#34427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -65 lines) Patch
M src/factory.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +8 lines, -20 lines 0 comments Download
M src/objects.cc View 3 chunks +12 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -20 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-02 11:53:34 UTC) #1
mvstanton
lgtm
4 years, 9 months ago (2016-03-02 12:05:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753213002/1
4 years, 9 months ago (2016-03-02 12:33:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 12:35:49 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 12:36:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fd5261d7f581210ff58a0a51b49051ba27c13ff
Cr-Commit-Position: refs/heads/master@{#34427}

Powered by Google App Engine
This is Rietveld 408576698