Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1753133003: Fix SkRadialGradient center discontinuity (Closed)

Created:
4 years, 9 months ago by f(malita)
Modified:
4 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkRadialGradient center discontinuity (AKA let's slow down radial gradients!) Avoid discontinuities when r ~= 0. BUG=skia:5052 R=reed@google.com,mtklein@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753133003 Committed: https://skia.googlesource.com/skia/+/0032a302ca8cddc7f6ca500b8096afa4888fc614

Patch Set 1 #

Patch Set 2 : v2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/effects/gradients/SkRadialGradient.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
f(malita)
This is what I think the fix for https://bugs.chromium.org/p/skia/issues/detail?id=5052 looks like. Unfortunately it slows raster ...
4 years, 9 months ago (2016-03-02 17:34:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753133003/1
4 years, 9 months ago (2016-03-02 17:34:30 UTC) #4
mtklein
lgtm
4 years, 9 months ago (2016-03-02 17:38:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 17:48:37 UTC) #7
f(malita)
Updated based on MikeR's idea to use a nearly-zero clamp and avoid the full blown ...
4 years, 9 months ago (2016-03-03 15:32:12 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753133003/20001
4 years, 9 months ago (2016-03-03 15:32:29 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 15:55:25 UTC) #12
mtklein
still lgtm. good idea
4 years, 9 months ago (2016-03-03 16:48:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753133003/20001
4 years, 9 months ago (2016-03-04 14:28:43 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 14:29:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0032a302ca8cddc7f6ca500b8096afa4888fc614

Powered by Google App Engine
This is Rietveld 408576698