Fix issue where errors aren't reported for a new overlay

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core' hide Resource;
 import 'dart:math' show max;
@@ skipping 533 matching lines @@
     Resource resource = resourceProvider.getResource(path);
     if (resource is! File) {
       return new ContextSourcePair(null, null);
     }
     File file = resource;
     {
       AnalysisContext containingContext = getContainingContext(path);
       if (containingContext != null) {
         Source source =
             ContextManagerImpl.createSourceInContext(containingContext, file);
-        return new ContextSourcePair(containingContext, source);
+        return new ContextSourcePair(containingContext, source,
+            contained: true);
       }
     }
     // try to find a context that analysed the file
     for (AnalysisContext context in analysisContexts) {
       Source source = ContextManagerImpl.createSourceInContext(context, file);
       SourceKind kind = context.getKindOf(source);
       if (kind != SourceKind.UNKNOWN) {
         return new ContextSourcePair(context, source);
       }
     }
@@ skipping 690 matching lines @@
         }
         return;
       }
       // Update all contexts.
       bool anyContextUpdated = false;
       for (InternalAnalysisContext context in analysisContexts) {
         List<Source> sources = context.getSourcesWithFullName(file);
         sources.forEach((Source source) {
           anyContextUpdated = true;
           if (context.handleContentsChanged(
-              source, oldContents, newContents, true)) {
+              source, oldContents, newContents, true,
+              explicit: contextSource.contained)) {

[skybrian, 2016/03/02 06:35:34]

Oops, this check should probably be something like:
  contextSource.context == context && contextSource.contained

             schedulePerformAnalysisOperation(context);
           } else {
             // When the client sends any change for a source, we should resend
             // subscribed notifications, even if there were no changes in the
             // source contents.
             // TODO(scheglov) consider checking if there are subscriptions.
             if (AnalysisEngine.isDartFileName(file)) {
               List<CompilationUnit> dartUnits =
                   context.ensureResolvedDartUnits(source);
               if (dartUnits != null) {
@@ skipping 157 matching lines @@
    */
   final AnalysisContext context;
 
   /**
    * The source that corresponds to the file.
    * May be `null` if the file is not a regular file.
    * If the file cannot be found in the [context], then it has a `file` uri.
    */
   final Source source;
 
-  ContextSourcePair(this.context, this.source);
+  /**
+   * If true, the source is contained within the directory associated
+   * with the context.
+   */
+  final bool contained;
+
+  ContextSourcePair(this.context, this.source, {this.contained: false});
 }
 
 /**
  * A [PriorityChangeEvent] indicates the set the priority files has changed.
  */
 class PriorityChangeEvent {
   final Source firstSource;
 
   PriorityChangeEvent(this.firstSource);
 }
@@ skipping 264 matching lines @@
   /**
    * The [PerformanceTag] for time spent in server request handlers.
    */
   static PerformanceTag serverRequests = new PerformanceTag('serverRequests');
 
   /**
    * The [PerformanceTag] for time spent in split store microtasks.
    */
   static PerformanceTag splitStore = new PerformanceTag('splitStore');
 }