mojo/dart/apptests/test_apps/pingpong/lib/main.dart - Issue 1753013002: Mojom runtime type info: New implementation for Dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/apptests/test_apps/pingpong/lib/main.dart

Issue 1753013002: Mojom runtime type info: New implementation for Dart. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Response to code review. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/apptests/test_apps/pingpong/lib/main.dart

diff --git a/mojo/dart/apptests/test_apps/pingpong/lib/main.dart b/mojo/dart/apptests/test_apps/pingpong/lib/main.dart

index ea47944a92361a9f88d78f903ea6d445a820b7f5..12eaaff1d464c653ce3f1a127d6cc8093c8d7b29 100644

--- a/mojo/dart/apptests/test_apps/pingpong/lib/main.dart

+++ b/mojo/dart/apptests/test_apps/pingpong/lib/main.dart

@@ -117,7 +117,8 @@ class PingPongApplication extends Application {

connection.remoteServiceProvider.close();

connection.provideService(PingPongService.serviceName,

- (endpoint) => new PingPongServiceImpl(this, endpoint));

+ (endpoint) => new PingPongServiceImpl(this, endpoint),

+ description: PingPongServiceStub.serviceDescription);

}