Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart

Issue 1753013002: Mojom runtime type info: New implementation for Dart. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Comment out 'Quit' test. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
diff --git a/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart b/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
index d5d8632b360da326d674fdf98026cdda0e5a3e18..1cde9d3c30e762cc057c74d8e057af644fe19b42 100644
--- a/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
+++ b/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
@@ -116,6 +116,12 @@ pingpongApptests(Application application, String url) {
await pingPongServiceProxy.close();
});
+ // Note(rudominer) Per request from @zra in
+ // https://codereview.chromium.org/1753013002, temporarily disabling this
+ // test because we believe it may be causing flakiness in
+ // service_describer_apptests.dart which is listed immediately following
+ // this test in dart_apptests/lib/main.dart.
+ /*
test('Quit', () async {
var pingPongServiceProxy = new PingPongServiceProxy.unbound();
application.connectToService(
@@ -123,5 +129,6 @@ pingpongApptests(Application application, String url) {
pingPongServiceProxy.ptr.quit();
await pingPongServiceProxy.close();
});
+ */
});
}

Powered by Google App Engine
This is Rietveld 408576698