Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart

Issue 1753013002: Mojom runtime type info: New implementation for Dart. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: No changes to sha1s Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 library pingpong_apptests; 5 library pingpong_apptests;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:mojo_apptest/apptest.dart'; 9 import 'package:mojo_apptest/apptest.dart';
10 import 'package:mojo/application.dart'; 10 import 'package:mojo/application.dart';
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 109
110 targetServiceProxy.ptr.ping(100); 110 targetServiceProxy.ptr.ping(100);
111 pongValue = await pingPongClient.waitForPong(); 111 pongValue = await pingPongClient.waitForPong();
112 expect(pongValue, equals(101)); 112 expect(pongValue, equals(101));
113 113
114 await pingPongClient.stub.close(); 114 await pingPongClient.stub.close();
115 await targetServiceProxy.close(); 115 await targetServiceProxy.close();
116 await pingPongServiceProxy.close(); 116 await pingPongServiceProxy.close();
117 }); 117 });
118 118
119 // Note(rudominer) Per request from @zra in
120 // https://codereview.chromium.org/1753013002, temporarily disabling this
121 // test because we believe it may be causing flakiness in
122 // service_describer_apptests.dart which is listed immediately following
123 // this test in dart_apptests/lib/main.dart.
124 /*
119 test('Quit', () async { 125 test('Quit', () async {
120 var pingPongServiceProxy = new PingPongServiceProxy.unbound(); 126 var pingPongServiceProxy = new PingPongServiceProxy.unbound();
121 application.connectToService( 127 application.connectToService(
122 "mojo:dart_pingpong", pingPongServiceProxy); 128 "mojo:dart_pingpong", pingPongServiceProxy);
123 pingPongServiceProxy.ptr.quit(); 129 pingPongServiceProxy.ptr.quit();
124 await pingPongServiceProxy.close(); 130 await pingPongServiceProxy.close();
125 }); 131 });
132 */
126 }); 133 });
127 } 134 }
OLDNEW
« no previous file with comments | « no previous file | mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698