Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3674)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 1752993002: cc : Delete LayerImpl::NoteLayerPropertyChangedForSubtree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index d94213b703390a6a1356c12944b23cc5750914c4..1df9ee9110133e43a4c5932c3a20156cecd1306b 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -699,6 +699,7 @@ class LayerTreeHostTestPropertyTreesChangedSync : public LayerTreeHostTest {
enum Animations {
OPACITY,
TRANSFORM,
+ FILTER,
END,
};
@@ -709,6 +710,7 @@ class LayerTreeHostTestPropertyTreesChangedSync : public LayerTreeHostTest {
void CommitCompleteOnThread(LayerTreeHostImpl* impl) override {
gfx::Transform transform;
+ FilterOperations filters;
switch (static_cast<Animations>(index_)) {
case OPACITY:
index_++;
@@ -728,6 +730,18 @@ class LayerTreeHostTestPropertyTreesChangedSync : public LayerTreeHostTest {
impl->active_tree()->root_layer()->OnTransformAnimated(transform);
PostSetNeedsCommitToMainThread();
break;
+ case FILTER:
+ index_++;
+ EXPECT_TRUE(impl->active_tree()->root_layer()->LayerPropertyChanged());
+ impl->active_tree()->root_layer()->ResetAllChangeTrackingForSubtree();
+ impl->active_tree()
+ ->property_trees()
+ ->transform_tree.ResetChangeTracking();
+ EXPECT_FALSE(impl->active_tree()->root_layer()->LayerPropertyChanged());
+ filters.Append(FilterOperation::CreateOpacityFilter(0.5f));
+ impl->active_tree()->root_layer()->OnFilterAnimated(filters);
+ PostSetNeedsCommitToMainThread();
+ break;
case END:
EXPECT_TRUE(impl->active_tree()->root_layer()->LayerPropertyChanged());
EndTest();

Powered by Google App Engine
This is Rietveld 408576698