Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1752983003: Moved ChromiumSubscribeUniform to web_gl (Closed)

Created:
4 years, 9 months ago by terry
Modified:
4 years, 9 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@integration
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Moved ChromiumSubscribeUniform to web_gl Fixed to return null if dictionary returned form blink is null Cleanup up logging/error reporting TBR=alanknight@google.com,jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc Committed: https://github.com/dart-lang/sdk/commit/e1a33e99819f44997d533b1f39eb63f2f5f2e9a2

Patch Set 1 #

Patch Set 2 : Merged from integration to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -22 lines) Patch
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/databasebuilder.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 3 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/dom/scripts/idlnode.py View 5 chunks +32 lines, -13 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
terry
Committed patchset #1 (id:1) manually as 01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc (presubmit successful).
4 years, 9 months ago (2016-03-02 16:07:57 UTC) #2
terry
4 years, 9 months ago (2016-03-02 16:15:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e1a33e99819f44997d533b1f39eb63f2f5f2e9a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698