Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-data.html

Issue 1752933002: [InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dtapuska's review, also add layout tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-data.html
diff --git a/third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-data.html b/third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-data.html
new file mode 100644
index 0000000000000000000000000000000000000000..d9524ca2df082244b23ff8fa1cbc2dcb663e2081
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-data.html
@@ -0,0 +1,41 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title>InputEvent: beforeinput data</title>
+<script src="../../../resources/testharness.js"></script>
+<script src="../../../resources/testharnessreport.js"></script>
+</head>
+<body>
+<div id="log"></div>
+<input type="text" id="txt">
+
yosin_UTC9 2016/03/15 08:32:32 nit: please remove an extra blank line.
+<script>
+test(function() {
+ var lastData = "";
+ var txt = document.getElementById('txt');
+ txt.addEventListener('beforeinput', function(e) {
+ lastData = e.data;
+ });
+ if (!window.eventSender) {
+ document.write('This test requires eventSender');
+ } else {
+ function testKeyDownData(key, modifiers, data) {
+ eventSender.keyDown(key, modifiers);
+ assert_equals(lastData, data, modifiers.toString() + "+" + key + " should produce data:" + data);
yosin_UTC9 2016/03/15 08:32:32 nit: It is better to use template string to improv
+ }
+
+ txt.focus();
+ // Typing
+ testKeyDownData('a', [], 'a');
+ testKeyDownData('4', [], '4');
+ testKeyDownData('backspace', [], '');
+ // Shift+foo doesn't work with eventSender, but actually |data| is correct according to manual tests.
+ // testKeyDownData('l', ['shiftKey'], 'L');
+ // testKeyDownData('6', ['shiftKey'], '^');
+ testKeyDownData(' ', [], ' ');
+ }
+}, "Testing beforeinput data");
+</script>
+
yosin_UTC9 2016/03/15 08:32:32 nit: please remove an extra blank line.
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698