Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/events/InputEvent.cpp

Issue 1752933002: [InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/InputEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/InputEvent.cpp b/third_party/WebKit/Source/core/events/InputEvent.cpp
index f7eb07a65d040c9cb0071ccc8a29dc660983bf09..e5bef79aa5f13af28dd80db64392c0af3e5ba1bb 100644
--- a/third_party/WebKit/Source/core/events/InputEvent.cpp
+++ b/third_party/WebKit/Source/core/events/InputEvent.cpp
@@ -5,9 +5,48 @@
#include "core/events/InputEvent.h"
#include "core/events/EventDispatcher.h"
+#include "public/platform/WebEditingCommandType.h"
namespace blink {
+namespace {
+
+const struct {
+ InputEvent::InputType inputType;
+ const char* stringName;
+} kInputTypeStringNameMap[] = {
+ {InputEvent::InputType::None, ""},
+ {InputEvent::InputType::InsertText, "insertText"},
+ {InputEvent::InputType::ReplaceContent, "replaceContent"},
+ {InputEvent::InputType::DeleteContent, "deleteContent"},
+ {InputEvent::InputType::DeleteComposedCharacter, "deleteComposedCharacter"},
+ {InputEvent::InputType::Undo, "undo"},
+ {InputEvent::InputType::Redo, "redo"},
+};
+
+static_assert(arraysize(kInputTypeStringNameMap) == static_cast<size_t>(InputEvent::InputType::NumberOfInputTypes),
+ "must handle all InputEvent::InputType");
+
+String convertInputTypeToString(InputEvent::InputType inputType)
+{
+ const auto& it = std::begin(kInputTypeStringNameMap) + static_cast<size_t>(inputType);
+ if (it >= std::begin(kInputTypeStringNameMap) && it < std::end(kInputTypeStringNameMap))
+ return AtomicString(it->stringName);
+ return emptyString();
+}
+
+InputEvent::InputType convertStringToInputType(const String& stringName)
+{
+ // TODO(chongz): Use binary search if the map goes larger.
+ for (const auto& entry : kInputTypeStringNameMap) {
+ if (stringName == entry.stringName)
+ return entry.inputType;
+ }
+ return InputEvent::InputType::None;
+}
+
+} // anonymous namespace
+
InputEvent::InputEvent()
{
}
@@ -15,6 +54,32 @@ InputEvent::InputEvent()
InputEvent::InputEvent(const AtomicString& type, const InputEventInit& initializer)
: UIEvent(type, initializer)
{
+ // TODO(ojan): We should find a way to prevent conversion like String->enum->String just in order to use initializer.
+ // See InputEvent::createBeforeInput() for the first conversion.
+ if (initializer.hasInputType())
+ m_inputType = convertStringToInputType(initializer.inputType());
+ if (initializer.hasData())
+ m_data = initializer.data();
+}
+
+/* static */
+InputEvent* InputEvent::createBeforeInput(InputType inputType, const String& data, EventCancelable cancelable)
+{
+ InputEventInit inputEventInit;
+
+ inputEventInit.setBubbles(true);
+ inputEventInit.setCancelable(cancelable == IsCancelable);
+ // TODO(ojan): We should find a way to prevent conversion like String->enum->String just in order to use initializer.
+ // See InputEvent::InputEvent() for the second conversion.
+ inputEventInit.setInputType(convertInputTypeToString(inputType));
+ inputEventInit.setData(data);
+
+ return InputEvent::create(EventTypeNames::beforeinput, inputEventInit);
+}
+
+String InputEvent::inputType() const
+{
+ return convertInputTypeToString(m_inputType);
}
bool InputEvent::isInputEvent() const
« no previous file with comments | « third_party/WebKit/Source/core/events/InputEvent.h ('k') | third_party/WebKit/Source/core/events/InputEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698