third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp - Issue 1752933002: [InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

Issue 1752933002: [InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('k') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

index 6f3dca9682f9a5f14349b60a1b60dfccc5cfdaa4..589c314f62ddb710bfe4845ddd83bf5c0d5b22c7 100644

--- a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

+++ b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

@@ -26,6 +26,7 @@

#include "core/editing/Editor.h"

+#include "core/editing/EditingUtilities.h"

#include "core/events/KeyboardEvent.h"

#include "core/frame/LocalFrame.h"

#include "core/page/EditorClient.h"

@@ -60,6 +61,10 @@ bool Editor::handleEditingKeyboardEvent(KeyboardEvent* evt)

if (!behavior().shouldInsertCharacter(*evt) || !canEdit())

return false;

+ // Return true to prevent default action. e.g. Space key scroll.

+ if (dispatchBeforeInputInsertText(evt->target(), evt->keyEvent()->text()) != DispatchEventResult::NotCanceled)

+ return true;

return insertText(evt->keyEvent()->text(), evt);

}