third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-order-typing-command.html - Issue 1752933002: [InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-order-typing-command.html

Issue 1752933002: [InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Yosin's review 3 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-data.html ('K') | « third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-inputtype.html ('k') | third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>InputEvent: beforeinput order on typing and command</title>

	5 <script src="../../../resources/testharness.js"></script>

	6 <script src="../../../resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <input type="text" id="txt">

	10 <script>

	11 test(function() {

	12 var eventList = ['keydown', 'keypress', 'beforeinput', 'input', 'keyup'];

	13 var expectedEventOrder = [

	14 // Pressing 'a'.

	15 'keydown', 'keypress', 'beforeinput', 'input', 'keyup',

	16 // Pressing Ctrl+z, eventSender.keyDown won't send 'keydown' and 'keyup' for Ctrl.
	ojan 2016/04/16 00:11:45 Make this a TODO? Make this a TODO? chongz 2016/04/18 22:54:47 Actually I realized this should be the correct beh Show quoted text On 2016/04/16 00:11:45, ojan wrote: > Make this a TODO? Actually I realized this should be the correct behavior since it's sending a single key 'z' with modifier 'ctrl'. I can add methods to send separate 'keydown'/'keyup' for 'ctrl' but I'm not sure it's worth it for the purpose of this test.
	17 /'keydown',/ 'keydown', 'beforeinput', 'input', 'keyup', /'keyup',/

	18 ];

	19 var actualEventOrder = [];

	20 var txt = document.getElementById('txt');

	21 eventList.forEach(function(eventType) {

	22 txt.addEventListener(eventType, function(event) {

	23 actualEventOrder.push(event.type);

	24 });

	25 });

	26 if (!window.eventSender) {

	27 document.write('This test requires eventSender');

	28 } else {

	29 txt.focus();

	30 eventSender.keyDown('a');

	31 var isMacOSX = navigator.userAgent.indexOf('Mac OS X') != -1;

	32 if (!isMacOSX) {

	33 // MacOS's eventSender does not work on hot keys other than arrows.

	34 eventSender.keyDown('z', ['ctrlKey']);

	35 assert_array_equals(actualEventOrder, expectedEventOrder, actualEven tOrder.toString());

	36 }

	37 }

	38 }, 'Testing beforeinput order on typing and command');

	39 </script>

	40 </body>

	41 </html>

OLD	NEW