[InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition

third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

 /*
  * Copyright (C) 2006, 2007 Apple, Inc.  All rights reserved.
  * Copyright (C) 2012 Google, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/editing/Editor.h"
 
+#include "core/events/InputEvent.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/frame/LocalFrame.h"
 #include "core/page/EditorClient.h"
 #include "platform/PlatformKeyboardEvent.h"
 
 namespace blink {
 
 bool Editor::handleEditingKeyboardEvent(KeyboardEvent* evt)
 {
     const PlatformKeyboardEvent* keyEvent = evt->keyEvent();
@@ skipping 14 matching lines @@
             return false;
         return command.execute(evt);
     }
 
     if (command.execute(evt))
         return true;
 
     if (!behavior().shouldInsertCharacter(*evt) || !canEdit())
         return false;
 
+    if (RuntimeEnabledFeatures::inputEventEnabled()) {
+        if (EventTarget* target = evt->target()) {
+            RefPtrWillBeRawPtr<InputEvent> beforeInputEvent = InputEvent::createBeforeInput("insertText", evt->keyEvent()->text());

[chongz, 2016/03/01 20:41:10]

Will replace "insertText" with constant command name.

[dtapuska, 2016/03/01 21:49:51]

you can likely store the atomic string in a static I think.

+            DispatchEventResult dispatchResult = target->dispatchEvent(beforeInputEvent);
+            if (dispatchResult != DispatchEventResult::NotCanceled)
+                return true;

[dtapuska, 2016/03/01 21:49:51]

I'm not certain returning true here is correct. As that indicates the keyboard
event was default handled doesn't it? I guess this might be ok; have to think
about it.

[chongz, 2016/03/04 19:46:50]

To my understanding the return value here should be 'defaultHandled() ||
defaultPrevented()', otherwise preventing beforeinput for space will cause
scroll I guess?

+        }
+    }
+
     return insertText(evt->keyEvent()->text(), evt);
 }
 
 void Editor::handleKeyboardEvent(KeyboardEvent* evt)
 {
     // Give the embedder a chance to handle the keyboard event.
     if (client().handleKeyboardEvent() || handleEditingKeyboardEvent(evt))
         evt->setDefaultHandled();
 }
 
 } // namespace blink