src/effects/SkColorFilters.cpp - Issue 175293002: Factory methods for heap-allocated SkColorFilter objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkColorFilters.cpp

Issue 175293002: Factory methods for heap-allocated SkColorFilter objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkColorFilters.cpp

diff --git a/src/effects/SkColorFilters.cpp b/src/effects/SkColorFilters.cpp

index ab32bc66363b7da18593df772958c940c2bfc978..bd5ecacdcedb7d7ed86017ee5a6d6172881f8c54 100644

--- a/src/effects/SkColorFilters.cpp

+++ b/src/effects/SkColorFilters.cpp

@@ -557,7 +557,7 @@ SkColorFilter* SkColorFilter::CreateLightingFilter(SkColor mul, SkColor add) {

SkIntToScalar(SkColorGetG(add)),

SkIntToScalar(SkColorGetB(add)),

0);

- return SkNEW_ARGS(SkColorMatrixFilter, (matrix));

+ return SkColorMatrixFilter::Create(matrix);

}

SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkColorFilter)

« no previous file with comments | « src/effects/SkColorFilterImageFilter.cpp ('k') | tests/GLProgramsTest.cpp » ('j') | no next file with comments »