Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: build/config/ios/ios_sdk.py

Issue 1752873002: Use bundle_data and create_bundle to add support for iOS app bundle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-create-bundle
Patch Set: Remove conditional around bundle_data, use response_file_contents, clean description of compile_xca… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/ios_sdk.gni ('k') | build/config/ios/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/ios_sdk.py
diff --git a/build/config/ios/ios_sdk.py b/build/config/ios/ios_sdk.py
index dfec4dbada9d88d80e3fe5167ec1b43a826e2beb..a94614aa8200cf36003caec9d910a02823690797 100644
--- a/build/config/ios/ios_sdk.py
+++ b/build/config/ios/ios_sdk.py
@@ -2,18 +2,57 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import os
import subprocess
import sys
-# This script returns the path to the SDK of the given type. Pass the type of
-# SDK you want, which is typically "iphone" or "iphonesimulator".
+# This script prints information about the build system, the operating
+# system and the iOS SDK (depending on the platform "iphonesimulator"
+# or "iphoneos" generally).
#
# In the GYP build, this is done inside GYP itself based on the SDKROOT
# variable.
-if len(sys.argv) != 2:
- print "Takes one arg (SDK to find)"
- sys.exit(1)
+def FormatVersion(version):
+ """Converts Xcode version to a format required for Info.plist."""
+ version = version.replace('.', '')
+ version = version + '0' * (3 - len(version))
+ return version.zfill(4)
-print subprocess.check_output(['xcodebuild', '-version', '-sdk',
- sys.argv[1], 'Path']).strip()
+
+def FillXcodeVersion(settings):
+ """Fills the Xcode version and build number into |settings|."""
+ lines = subprocess.check_output(['xcodebuild', '-version']).splitlines()
+ settings['xcode_version'] = FormatVersion(lines[0].split()[-1])
+ settings['xcode_build'] = lines[-1].split()[-1]
+
+
+def FillMachineOSBuild(settings):
+ """Fills OS build number into |settings|."""
+ settings['machine_os_build'] = subprocess.check_output(
+ ['sw_vers', '-buildVersion']).strip()
+
+
+def FillSDKPathAndVersion(settings, platform):
+ """Fills the SDK path and version for |platform| into |settings|."""
+ lines = subprocess.check_output(['xcodebuild', '-version', '-sdk',
+ platform, 'Path', 'SDKVersion', 'ProductBuildVersion']).splitlines()
+ settings['ios_sdk_path'] = lines[0]
+ settings['ios_sdk_version'] = lines[1]
+ settings['ios_sdk_build'] = lines[2]
+
+
+if __name__ == '__main__':
+ if len(sys.argv) != 2:
+ sys.stderr.write(
+ 'usage: %s [iphoneos|iphonesimulator]\n' %
+ os.path.basename(sys.argv[0]))
+ sys.exit(1)
+
+ settings = {}
+ FillSDKPathAndVersion(settings, sys.argv[1])
+ FillMachineOSBuild(settings)
+ FillXcodeVersion(settings)
+
+ for key in sorted(settings):
+ print '%s="%s"' % (key, settings[key])
« no previous file with comments | « build/config/ios/ios_sdk.gni ('k') | build/config/ios/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698