Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: base/BUILD.gn

Issue 1752873002: Use bundle_data and create_bundle to add support for iOS app bundle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-create-bundle
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/ios/BuildInfo.plist » ('j') | build/config/ios/ios_gen_plist.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1602 matching lines...) Expand 10 before | Expand all | Expand 10 after
1613 sources = [ 1613 sources = [
1614 "profiler/test_support_library.cc", 1614 "profiler/test_support_library.cc",
1615 ] 1615 ]
1616 deps = [ 1616 deps = [
1617 "//build/config/sanitizers:deps", 1617 "//build/config/sanitizers:deps",
1618 ] 1618 ]
1619 } 1619 }
1620 } 1620 }
1621 } 1621 }
1622 1622
1623 if (is_ios) {
1624 bundle_data("base_unittests_bundle_data") {
brettw 2016/03/15 18:02:29 Can bundles be set up in such a way that we don't
sdefresne 2016/03/16 09:58:49 Removed the conditional (since Mac does not curren
1625 sources = [
1626 "test/data",
1627 ]
1628 outputs = [
1629 "{{bundle_resources_dir}}/{{source_root_relative_dir}}/{{source_file_part} }",
1630 ]
1631 }
1632 }
1633
1623 test("base_unittests") { 1634 test("base_unittests") {
1624 sources = [ 1635 sources = [
1625 "allocator/tcmalloc_unittest.cc", 1636 "allocator/tcmalloc_unittest.cc",
1626 "android/application_status_listener_unittest.cc", 1637 "android/application_status_listener_unittest.cc",
1627 "android/content_uri_utils_unittest.cc", 1638 "android/content_uri_utils_unittest.cc",
1628 "android/jni_android_unittest.cc", 1639 "android/jni_android_unittest.cc",
1629 "android/jni_array_unittest.cc", 1640 "android/jni_array_unittest.cc",
1630 "android/jni_string_unittest.cc", 1641 "android/jni_string_unittest.cc",
1631 "android/library_loader/library_prefetcher_unittest.cc", 1642 "android/library_loader/library_prefetcher_unittest.cc",
1632 "android/path_utils_unittest.cc", 1643 "android/path_utils_unittest.cc",
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
1874 ":i18n", 1885 ":i18n",
1875 ":message_loop_tests", 1886 ":message_loop_tests",
1876 "//base/test:run_all_unittests", 1887 "//base/test:run_all_unittests",
1877 "//base/test:test_support", 1888 "//base/test:test_support",
1878 "//base/third_party/dynamic_annotations", 1889 "//base/third_party/dynamic_annotations",
1879 "//testing/gmock", 1890 "//testing/gmock",
1880 "//testing/gtest", 1891 "//testing/gtest",
1881 "//third_party/icu", 1892 "//third_party/icu",
1882 ] 1893 ]
1883 1894
1895 if (is_ios) {
1896 deps += [ ":base_unittests_bundle_data" ]
1897 }
1898
1884 # Some unittests depend on the ALLOCATOR_SHIM macro. 1899 # Some unittests depend on the ALLOCATOR_SHIM macro.
1885 configs += [ "//base/allocator:allocator_shim_define" ] 1900 configs += [ "//base/allocator:allocator_shim_define" ]
1886 1901
1887 data = [ 1902 data = [
1888 "test/data/", 1903 "test/data/",
1889 ] 1904 ]
1890 1905
1891 # Allow more direct string conversions on platforms with native utf8 1906 # Allow more direct string conversions on platforms with native utf8
1892 # strings 1907 # strings
1893 if (is_mac || is_ios || is_chromeos) { 1908 if (is_mac || is_ios || is_chromeos) {
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
2186 2201
2187 # GYP: //base.gyp:base_java_unittest_support 2202 # GYP: //base.gyp:base_java_unittest_support
2188 android_library("base_java_unittest_support") { 2203 android_library("base_java_unittest_support") {
2189 deps = [ 2204 deps = [
2190 ":base_java", 2205 ":base_java",
2191 ] 2206 ]
2192 java_files = 2207 java_files =
2193 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2208 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2194 } 2209 }
2195 } 2210 }
OLDNEW
« no previous file with comments | « no previous file | build/config/ios/BuildInfo.plist » ('j') | build/config/ios/ios_gen_plist.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698