Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: build/config/ios/ios_sdk.gni

Issue 1752873002: Use bundle_data and create_bundle to add support for iOS app bundle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-create-bundle
Patch Set: Remove conditional around bundle_data, use response_file_contents, clean description of compile_xca… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/ios/ios_gen_plist.py ('k') | build/config/ios/ios_sdk.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # SDK path to use. When empty this will use the default SDK based on the 6 # SDK path to use. When empty this will use the default SDK based on the
7 # value of use_ios_simulator. 7 # value of use_ios_simulator.
8 ios_sdk_path = "" 8 ios_sdk_path = ""
9 ios_sdk_name = ""
10 ios_sdk_version = ""
11 ios_sdk_platform = ""
12 xcode_version = ""
13 xcode_build = ""
14 machine_os_build = ""
9 15
10 use_ios_simulator = target_cpu == "x86" || target_cpu == "x64" 16 use_ios_simulator = target_cpu == "x86" || target_cpu == "x64"
11 17
12 # Version of iOS that we're targeting. 18 # Version of iOS that we're targeting.
13 ios_deployment_target = "9.0" 19 ios_deployment_target = "9.0"
14 20
15 # The iOS Code signing identity to use 21 # The iOS Code signing identity to use
16 # TODO(GYP), TODO(sdfresne): Consider having a separate 22 # TODO(GYP), TODO(sdfresne): Consider having a separate
17 # ios_enable_code_signing_flag=<bool> flag to make the invocation clearer. 23 # ios_enable_code_signing_flag=<bool> flag to make the invocation clearer.
18 ios_enable_code_signing = true 24 ios_enable_code_signing = true
19 ios_code_signing_identity = "" 25 ios_code_signing_identity = ""
20 } 26 }
21 27
22 if (ios_sdk_path == "") { 28 if (ios_sdk_path == "") {
23 # Compute default target. 29 # Compute default target.
24 if (use_ios_simulator) { 30 if (use_ios_simulator) {
25 _ios_sdk_to_query = "iphonesimulator" 31 ios_sdk_name = "iphonesimulator"
32 ios_sdk_platform = "iPhoneSimulator"
26 } else { 33 } else {
27 _ios_sdk_to_query = "iphoneos" 34 ios_sdk_name = "iphoneos"
35 ios_sdk_platform = "iPhoneOS"
28 } 36 }
29 _ios_sdk_result = 37 _ios_sdk_result = exec_script("ios_sdk.py", [ ios_sdk_name ], "scope")
30 exec_script("ios_sdk.py", [ _ios_sdk_to_query ], "list lines") 38 ios_sdk_path = _ios_sdk_result.ios_sdk_path
31 ios_sdk_path = _ios_sdk_result[0] 39 ios_sdk_version = _ios_sdk_result.ios_sdk_version
40 ios_sdk_build = _ios_sdk_result.ios_sdk_build
41 xcode_version = _ios_sdk_result.xcode_version
42 xcode_build = _ios_sdk_result.xcode_build
43 machine_os_build = _ios_sdk_result.machine_os_build
44 if (use_ios_simulator) {
45 # This is weird, but Xcode sets DTPlatformBuild to an empty field for
46 # simulator builds.
47 ios_platform_build = ""
48 } else {
49 ios_platform_build = ios_sdk_build
50 }
32 } 51 }
33 52
34 if (use_ios_simulator) { 53 if (use_ios_simulator) {
35 # Always disable code signing on the simulator 54 # Always disable code signing on the simulator
36 ios_enable_code_signing = false 55 ios_enable_code_signing = false
37 ios_code_signing_identity = "" 56 ios_code_signing_identity = ""
38 } 57 }
39 58
40 if (ios_enable_code_signing) { 59 if (ios_enable_code_signing) {
41 # If an identity is not provided, look for one on the host 60 # If an identity is not provided, look for one on the host
42 if (ios_code_signing_identity == "") { 61 if (ios_code_signing_identity == "") {
43 _ios_identities = exec_script("find_signing_identity.py", [], "list lines") 62 _ios_identities = exec_script("find_signing_identity.py", [], "list lines")
44 ios_code_signing_identity = _ios_identities[0] 63 ios_code_signing_identity = _ios_identities[0]
45 } 64 }
46 65
47 if (ios_code_signing_identity == "") { 66 if (ios_code_signing_identity == "") {
48 print("Tried to prepare a device build without specifying a code signing") 67 print("Tried to prepare a device build without specifying a code signing")
49 print("identity and could not detect one automatically either.") 68 print("identity and could not detect one automatically either.")
50 print("TIP: Simulator builds dont require code signing...") 69 print("TIP: Simulator builds dont require code signing...")
51 assert(false) 70 assert(false)
52 } 71 }
53 } 72 }
OLDNEW
« no previous file with comments | « build/config/ios/ios_gen_plist.py ('k') | build/config/ios/ios_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698