content/test/data/page_with_click_handler.html - Issue 1752833002: Implement Gesture event hit testing/forwarding for OOPIF.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/page_with_click_handler.html

Issue 1752833002: Implement Gesture event hit testing/forwarding for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wjmCFTouch.v2

Patch Set: Address comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html style="width: 100%; height: 100%">

	3 <head>

	4 <script>

	5 clicksReceived = 0;

	6

	7 function clickHandler(e) {

	8 var clickResult = document.getElementById("click-results");

	9 clicksReceived++;

	10 clickResult.innerHTML = clicksReceived + " clicks received";
	nasko 2016/03/03 19:01:24 Since you are sticking plaintext in the element, w Since you are sticking plaintext in the element, why not use textContent? wjmaclean 2016/03/03 22:27:50 Done. Show quoted text On 2016/03/03 19:01:24, nasko wrote: > Since you are sticking plaintext in the element, why not use textContent? Done.
	11 }

	12

	13 function getClickStatus() {

	14 var clickResult = document.getElementById("click-results");

	15 return clickResult.innerHTML;

	16 }

	17

	18 window.addEventListener('load', function(){ // on page load
	nasko 2016/03/03 19:01:24 nit: The comment is not needed, it is fairly obvio nit: The comment is not needed, it is fairly obvious this is a page load handler. wjmaclean 2016/03/03 22:27:50 Done. Show quoted text On 2016/03/03 19:01:24, nasko wrote: > nit: The comment is not needed, it is fairly obvious this is a page load > handler. Done.
	19 document.body.addEventListener('click',

	20 function(e){

	21 clickHandler(e);

	22 }, false);

	23 }, false);

	24 </script>

	25 </head>

	26

	27 <!-- Be sure to set 100% width/height so the test can determine an appropriate

	28 screen region for targeting events. -->

	29 <body style="width: 100%; height: 100%">

	30 Page with Click Handler

	31 <div id="click-results">0 clicks received</div>

	32 </body>

	33 </html>

OLD	NEW

« content/browser/site_per_process_browsertest.cc ('K') | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »