DM: don't run rtree when kSkipTiled is set.

dm/DMReplayTask.cpp

Index: dm/DMReplayTask.cpp
diff --git a/dm/DMReplayTask.cpp b/dm/DMReplayTask.cpp
index 763684a087031fe9ccb98456177729be5ae97a33..3d010358c25776ef2ab4a81e322322ea8a531995 100644
--- a/dm/DMReplayTask.cpp
+++ b/dm/DMReplayTask.cpp
@@ -41,7 +41,7 @@ bool ReplayTask::shouldSkip() const {
     }
 
     if (FLAGS_rtree && fUseRTree) {
-        return fGM->getFlags() & skiagm::GM::kSkipTiled_Flag;
+        return (fGM->getFlags() & skiagm::GM::kSkipTiled_Flag) != 0;

[scroggo, 2014/02/21 19:21:28]

You don't like SkToBool?

[mtklein, 2014/02/21 19:28:14]

Seemed clearer to test != 0 explicitly since we're doing bit logic.  SkToBool
makes me think we're dealing with the world of booleans and short circuiting
logic, when we're really dealing with the slightly-different world of bits.

I'd even happier to write return SkIsBitSet(fGM->getFlags(),
skiagm::GM::kSkipTiled_Flag);, but for now I just wanted things to build.

[scroggo, 2014/02/21 19:29:18]

sgtm

     }
     if (FLAGS_replay && !fUseRTree) {
         return false;