Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1752753002: Fix bug with multiple directives in the preparser (Closed)

Created:
4 years, 9 months ago by nickie
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bug with multiple directives in the preparser The preparser should ignore "use strong" if the --strong_mode flag is not turned on, but this should not stop processing subsequent directives. R=rossberg@chromium.org BUG= LOG=N Committed: https://crrev.com/86a9ef31c70311aa33fa90e1b5b39aa99e3bae41 Cr-Commit-Position: refs/heads/master@{#34392}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/parsing/preparser.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
nickie
4 years, 9 months ago (2016-03-01 12:00:28 UTC) #1
rossberg
LGTM
4 years, 9 months ago (2016-03-01 12:16:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752753002/1
4 years, 9 months ago (2016-03-01 12:34:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16269)
4 years, 9 months ago (2016-03-01 12:40:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752753002/1
4 years, 9 months ago (2016-03-01 13:08:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16282)
4 years, 9 months ago (2016-03-01 13:17:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752753002/20001
4 years, 9 months ago (2016-03-01 13:22:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 13:58:03 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 13:59:18 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86a9ef31c70311aa33fa90e1b5b39aa99e3bae41
Cr-Commit-Position: refs/heads/master@{#34392}

Powered by Google App Engine
This is Rietveld 408576698