third_party/WebKit/Source/core/svg/SVGTitleElement.h - Issue 1752713002: Fix SVGDocument return title that is not a child of the root element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTitleElement.h

Issue 1752713002: Fix SVGDocument return title that is not a child of the root element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Document.cpp ('K') | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/svg/SVGTitleElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGTitleElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGTitleElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGTitleElement.h b/third_party/WebKit/Source/core/svg/SVGTitleElement.h

index 31e97532f5ea6ef5e671a13b70abede658e46c36..97e6d59afd5083b6ad3fa138487cf951b3b85517 100644

--- a/third_party/WebKit/Source/core/svg/SVGTitleElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGTitleElement.h

@@ -30,6 +30,7 @@ class SVGTitleElement final : public SVGElement {

public:

DECLARE_NODE_FACTORY(SVGTitleElement);

+ void setText(const String &value);

private:

fs 2016/03/03 15:49:45 Add space between the above two lines.

hyunjunekim2 2016/03/04 11:29:32 Done.

explicit SVGTitleElement(Document&);

@@ -38,6 +39,8 @@ private:

void childrenChanged(const ChildrenChange&) override;

bool layoutObjectIsNeeded(const ComputedStyle&) override { return false; }

+ bool m_ignoreTitleUpdatesWhenChildrenChange;

};

} // namespace blink