third_party/WebKit/LayoutTests/svg/dom/svg-document-test.html - Issue 1752713002: Fix SVGDocument return title that is not a child of the root element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/svg-document-test.html

Issue 1752713002: Fix SVGDocument return title that is not a child of the root element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt ('K') | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/dom/svg-document-test-expected.txt » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description("Tests that get and set document.title.");
	fs 2016/03/01 15:49:03 Not sure if this test tests anything that the web- Not sure if this test tests anything that the web-platform-test (above) doesn't. If it does then please rewrite it to use testharness.js - else remove it. hyunjunekim2 2016/03/03 14:06:10 Done.removed this test, and added mutation test fo Show quoted text On 2016/03/01 15:49:03, fs wrote: > Not sure if this test tests anything that the web-platform-test (above) doesn't. > If it does then please rewrite it to use testharness.js - else remove it. Done.removed this test, and added mutation test for title of svg document.
	9

	10 var svgDoc = document.implementation.createDocument("http://www.w3.org/2000/svg" , "svg", null);

	11 var g = svgDoc.createElementNS("http://www.w3.org/2000/svg", "g");

	12 var title = svgDoc.createElementNS("http://www.w3.org/2000/svg", "title");

	13 title.textContent = "foo";

	14 g.appendChild(title);

	15 svgDoc.documentElement.appendChild(g);

	16 shouldBeEqualToString("svgDoc.title", "");

	17

	18 svgDoc.title = "foo";

	19 shouldBeEqualToString("svgDoc.title", "foo");

	20 shouldBe("svgDoc.documentElement.childNodes.length","2");

	21 svgDoc.title = "bar";

	22 shouldBeEqualToString("svgDoc.title", "bar");

	23 shouldBe("svgDoc.documentElement.childNodes.length","2");

	24 </script>

	25 </body>

	26 </html>

OLD	NEW