Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 1752703003: Fix transform feedback bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set correct cached buffer in command buffer Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation.cc
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc
index fc051b1fad3bfa6b1a9d2c61c2999cde84f192ee..e2c2d5f37334a684783bf95e93bd8bb9b142a970 100644
--- a/gpu/command_buffer/client/gles2_implementation.cc
+++ b/gpu/command_buffer/client/gles2_implementation.cc
@@ -3820,6 +3820,20 @@ void GLES2Implementation::BindBufferBaseHelper(
GLenum target, GLuint index, GLuint buffer_id) {
// TODO(zmo): See note #1 above.
// TODO(zmo): See note #2 above.
+ switch (target) {
Zhenyao Mo 2016/03/02 17:09:36 You will need to validate index before caching the
qiankun 2016/03/03 10:14:15 Done.
+ case GL_TRANSFORM_FEEDBACK_BUFFER:
+ if (bound_transform_feedback_buffer_ != buffer_id) {
+ bound_transform_feedback_buffer_ = buffer_id;
+ }
+ break;
+ case GL_UNIFORM_BUFFER:
+ if (bound_uniform_buffer_ != buffer_id) {
+ bound_uniform_buffer_ = buffer_id;
+ }
+ break;
+ default:
+ break;
+ }
GetIdHandler(id_namespaces::kBuffers)->MarkAsUsedForBind(
this, target, index, buffer_id, &GLES2Implementation::BindBufferBaseStub);
}
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698